Re: [openssl-project] Current votes FYI

2018-05-23 Thread Salz, Rich
Dang, you’re right.

I’ll re-run the vote.  But for now I reverted the website commit.

From: Tim Hudson 
Reply-To: "openssl-project@openssl.org" 
Date: Wednesday, May 23, 2018 at 5:00 PM
To: "openssl-project@openssl.org" 
Subject: Re: [openssl-project] Current votes FYI

No that vote does not pass. All votes require participation by a majority of 
active members. Failure to have a majority participation causes a vote to fail.

With only three out of eight members voting this vote simply did not pass.

Tim.

On Thu, 24 May 2018, 12:59 am Salz, Rich, 
> wrote:
Another update

VOTE: Remove the second paragraph ("Binary compatibility...improve security")
from the release strategy.

 +1: 2
 0: 1
-1: 0
No vote: 5

The vote passed.


___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project

Re: [openssl-project] Current votes FYI

2018-05-23 Thread Tim Hudson
No that vote does not pass. All votes require participation by a majority
of active members. Failure to have a majority participation causes a vote
to fail.

With only three out of eight members voting this vote simply did not pass.

Tim.


On Thu, 24 May 2018, 12:59 am Salz, Rich,  wrote:

> Another update
>
> VOTE: Remove the second paragraph ("Binary compatibility...improve
> security")
> from the release strategy.
>
>  +1: 2
>  0: 1
> -1: 0
> No vote: 5
>
> The vote passed.
>
>
> ___
> openssl-project mailing list
> openssl-project@openssl.org
> https://mta.openssl.org/mailman/listinfo/openssl-project
>
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project

Re: [openssl-project] build/test before merging

2018-05-23 Thread Matt Caswell


On 23/05/18 16:50, Benjamin Kaduk wrote:
> On Wed, May 23, 2018 at 03:12:30PM +, Dr. Matthias St. Pierre wrote:
>>> So do you guys use the ghmerge script or own procedures?  I'm curious.
>>
>> At the beginnning, I tried to use ghmerge but it was not flexible
>> enough for my needs. In particular, it only gives me the choice
>> between squashing everything or leaving everything as it is. Most
>> notably, it does not support partial squashing by interactive
>> rebasing. Or alternatively: pausing + letting me fix something +
>> resuming. What I also dislike is that it uses a lot of GitHub API
> 
> Sorry for partially hijacking the thread, but this reminds me that
> several people have started using the "git commit --fixup" tooling,
> which is in general helpful for the reviewer (to know what the
> squashing intention is).

It's also helpful because it preserves the history of the review (you
can see what changed since the last time you looked at it).

> 
> But I am curious if we currently do and/or should have a commit hook
> on git.openssl.org to reject commits that start with "!fixup".

Not that I know of. We probably should have. A quick check reveals two
such commits that have made it into master...both mine unfortunately :-(

Matt

___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] build/test before merging

2018-05-23 Thread Dr. Matthias St. Pierre
> But I am curious if we currently do and/or should have a commit hook on 
> git.openssl.org to reject commits that start with "!fixup".

We probably don't, but it's a good idea to have it.

Matthias

___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] build/test before merging

2018-05-23 Thread Benjamin Kaduk
On Wed, May 23, 2018 at 03:12:30PM +, Dr. Matthias St. Pierre wrote:
> > So do you guys use the ghmerge script or own procedures?  I'm curious.
> 
> At the beginnning, I tried to use ghmerge but it was not flexible
> enough for my needs. In particular, it only gives me the choice
> between squashing everything or leaving everything as it is. Most
> notably, it does not support partial squashing by interactive
> rebasing. Or alternatively: pausing + letting me fix something +
> resuming. What I also dislike is that it uses a lot of GitHub API

Sorry for partially hijacking the thread, but this reminds me that
several people have started using the "git commit --fixup" tooling,
which is in general helpful for the reviewer (to know what the
squashing intention is).

But I am curious if we currently do and/or should have a commit hook
on git.openssl.org to reject commits that start with "!fixup".

-Ben
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] build/test before merging

2018-05-23 Thread Dr. Matthias St. Pierre
  
> +1 for python! :)

Well, if this is a "go for it"... ;-)

Oh, and I forgot to mention 'ghtool cherry-pick {110,102}'

___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] build/test before merging

2018-05-23 Thread Salz, Rich
>Unfortunately, I didn't have time to follow my vision yet. Also, it would 
> have been easier for me to do it in Python than in Perl.
  
+1 for python! :)

___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


[openssl-project] Some failing builds in travis?

2018-05-23 Thread Viktor Dukhovni

https://travis-ci.org/openssl/openssl/jobs/382694134
https://api.travis-ci.org/v3/job/382694134/log.txt

Test Summary Report
---
../test/recipes/70-test_comp.t   (Wstat: 26624 Tests: 0 Failed: 
0)
  Non-zero exit status: 104
  Parse errors: No plan found in TAP output
../test/recipes/70-test_key_share.t  (Wstat: 26624 Tests: 0 Failed: 
0)
  Non-zero exit status: 104
  Parse errors: No plan found in TAP output
../test/recipes/70-test_sslrecords.t (Wstat: 26624 Tests: 17 
Failed: 0)
  Non-zero exit status: 104
  Parse errors: Bad plan.  You planned 18 tests but ran 17.
../test/recipes/70-test_sslsigalgs.t (Wstat: 26624 Tests: 0 Failed: 
0)
  Non-zero exit status: 104
  Parse errors: No plan found in TAP output
../test/recipes/70-test_sslsignature.t   (Wstat: 26624 Tests: 0 Failed: 
0)
  Non-zero exit status: 104
  Parse errors: No plan found in TAP output
../test/recipes/70-test_sslversions.t(Wstat: 26624 Tests: 4 Failed: 
0)
  Non-zero exit status: 104
  Parse errors: Bad plan.  You planned 7 tests but ran 4.
../test/recipes/70-test_tls13cookie.t(Wstat: 26624 Tests: 0 Failed: 
0)
  Non-zero exit status: 104
  Parse errors: No plan found in TAP output
../test/recipes/70-test_tls13kexmodes.t  (Wstat: 19712 Tests: 0 Failed: 
0)
  Non-zero exit status: 77
  Parse errors: No plan found in TAP output
../test/recipes/70-test_tls13messages.t  (Wstat: 8192 Tests: 1 Failed: 
0)
  Non-zero exit status: 32
  Parse errors: Bad plan.  You planned 16 tests but ran 1.
../test/recipes/70-test_tls13psk.t   (Wstat: 19712 Tests: 0 Failed: 
0)
  Non-zero exit status: 77
  Parse errors: No plan found in TAP output
../test/recipes/70-test_tlsextms.t   (Wstat: 26624 Tests: 9 Failed: 
0)
  Non-zero exit status: 104
  Parse errors: Bad plan.  You planned 10 tests but ran 9.
Files=147, Tests=1249, 358 wallclock secs ( 5.94 usr  1.09 sys + 287.60 cusr 
53.16 csys = 347.79 CPU)
Result: FAIL
make[1]: *** [_tests] Error 1
make[1]: Leaving directory `/home/travis/build/openssl/openssl'
make: *** [tests] Error 2
+/ MAKE TEST FAILED

-- 
Viktor.

___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] build/test before merging

2018-05-23 Thread Matt Caswell


On 23/05/18 01:43, Salz, Rich wrote:
> > I do the same, but I am reluctant having a script doing it for me using 
> some fixed recipe...
> 
>>I'm happy doing the build/test manually before merging, too.
>   
> 
> So do you guys use the ghmerge script or own procedures?  I'm curious.

I tried it once. Didn't like it, so I always do my own procedure.

Matt

___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project


Re: [openssl-project] build/test before merging

2018-05-23 Thread Richard Levitte
In message <25feb2a8-b363-443d-bae8-c47d1ad92...@akamai.com> on Wed, 23 May 
2018 00:43:58 +, "Salz, Rich"  said:

rsalz> > I do the same, but I am reluctant having a script doing it for me 
using some fixed recipe...
rsalz> 
rsalz> >I'm happy doing the build/test manually before merging, too.
rsalz>   
rsalz> 
rsalz> So do you guys use the ghmerge script or own procedures?  I'm curious.

I use addrev and git commands.  ghmerge does too much for my taste.

-- 
Richard Levitte levi...@openssl.org
OpenSSL Project http://www.openssl.org/~levitte/
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project