Re: [openssl-project] Release Criteria Update

2018-09-05 Thread Tim Hudson 
 On Thu, Sep 6, 2018 at 8:59 AM, Matt Caswell  wrote:
> #7113 An alternative to address the SM2 ID issues
> (an alternative to the older PR, #6757)
>
> Updates made following earlier review. Awaiting another round of reviews.
> Owner: Paul Yang

All the previous comments have been addressed. I noted two missing SM2err
calls on malloc failure and a typo in SM2.pod.
I've approved it conditional on those being fixed.

Tim.
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project

Re: [openssl-project] Release Criteria Update

2018-09-05 Thread Benjamin Kaduk 
On Wed, Sep 05, 2018 at 11:59:34PM +0100, Matt Caswell wrote:
> Today's update is that we still have 6 open PRs for 1.1.1. 5 of these
> are the same as yesterday. The 1 that was marked as "ready" yesterday
> has now been merged, and a new PR addressing issue #7014 has been opened.
> 
> There are still 2 open issues for 1.1.1 but both of these are now being
> addressed by one of the open PRs.
> 
> That means there are still 4 "critical path" PRs open:
> 
> #7115 Restore historical SSL_get_servername() behavior
> 
> Updates made following earlier review. Ready for another round of reviews??
> Owner: Ben.

I believe it's ready for another round of reviews, yes.
Do we think we want to wait for confirmation from @MSP-Greg?

-Ben
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project

Re: [openssl-project] Release Criteria Update

2018-09-05 Thread Matt Caswell 
Today's update is that we still have 6 open PRs for 1.1.1. 5 of these
are the same as yesterday. The 1 that was marked as "ready" yesterday
has now been merged, and a new PR addressing issue #7014 has been opened.

There are still 2 open issues for 1.1.1 but both of these are now being
addressed by one of the open PRs.

That means there are still 4 "critical path" PRs open:

#7115 Restore historical SSL_get_servername() behavior

Updates made following earlier review. Ready for another round of reviews??
Owner: Ben.

#7114 Process KeyUpdate and NewSessionTicket messages after a close_notify
(an alternative to the older PR, #7058)

Currently in review. Awaiting some updates following review feedback.
Owner: Matt.

#7113 An alternative to address the SM2 ID issues
(an alternative to the older PR, #6757)

Updates made following earlier review. Awaiting another round of reviews.
Owner: Paul Yang

#7073 Support EdDSA in apps/speed

Updates made following earlier review. Awaiting another round of reviews.
Owner: Paul Yang


Matt

On 04/09/18 17:11, Matt Caswell wrote:
> Current status of the 1.1.1 PRs/issues:
> 
> There are currently 6 open PRs for 1.1.1. However in 2 cases there are 2
> alternative implementations for the same thing - so really there are
> only 4 issues being addressed. One of these is in the "ready" state.
> 
> The remaining 3 are:
> 
> #7114 Process KeyUpdate and NewSessionTicket messages after a close_notify
> (an alternative to the older PR, #7058)
> 
> Awaiting review
> Owner: Matt
> 
> #7113 An alternative to address the SM2 ID issues
> (an alternative to the older PR, #6757)
> 
> Currently being reviewed
> Owner: Paul Yang
> 
> #7073 Support EdDSA in apps/speed
> 
> Awaiting updates following review comments
> Owner: Paul Yang
> 
> 
> There are 2 open issues for 1.1.1. One of these is being addressed by
> PR#7073 above. The other one is:
> 
> #7014 TLSv1.2 SNI hostname works in 1.1.0h, not in 1.1.1 master (as of
> 18-Aug)
> 
> This one seems stuck!! No clear way forward as yet.
> 
> Ben - any views?
> 
> 
> Matt
> 
___
openssl-project mailing list
openssl-project@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-project