Re: Build failures on master
This keeps happening because the standard tests don't include no-fips or no-pic or no-module (the latter two will disable fips too), so we keep not hitting this hurdle in PRs unless we have extended tests run (done by having '[extended tests]' in the commit message). We should add a configuration with 'no-fips' among our standard tests, so this becomes automatically visible in PRs. The issue with the tests? Doing FIPS tests without checking if 'fips' is disabled or not. Cheers, Richard On Sat, 28 Sep 2019 22:25:04 +0200, Dr. Matthias St. Pierre wrote: > > Hi, > > since my last commit on master did not build successfully, I checked the CIs. > It turned out that a lot of tests are failing, and they have been for quite a > while now. > > https://travis-ci.org/openssl/openssl/builds/590874649?utm_source=github_status&utm_medium=notification > > Apart from the well known trio boringssl, krb5, and pyca, there are some new > failing tests. > It would be nice if we could put some effort into fixing them in order to get > back to having > stable successful builds on master again. The build failures on master also > affect the > pull request CI builds and if the failure persists, people stop checking > their red crosses. > > Matthias > > > -- > > https://travis-ci.org/openssl/openssl/jobs/590874663 > > 80-test_ssl_old.t(Wstat: 256 Tests: 6 Failed: 1) > Failed test: 3 > Non-zero exit status: 1 > > > https://travis-ci.org/openssl/openssl/jobs/590874664 > > Test Summary Report > --- > 95-test_external_boringssl.t (Wstat: 256 Tests: 1 Failed: 1) > Failed test: 1 > Non-zero exit status: 1 > 95-test_external_krb5.t (Wstat: 256 Tests: 1 Failed: 1) > Failed test: 1 > Non-zero exit status: 1 > 95-test_external_pyca.t (Wstat: 256 Tests: 1 Failed: 1) > Failed test: 1 > Non-zero exit status: 1 > > https://travis-ci.org/openssl/openssl/jobs/590874669 > > Test Summary Report > --- > 30-test_evp.t(Wstat: 256 Tests: 19 Failed: 1) > Failed test: 1 > Non-zero exit status: 1 > 30-test_evp_fetch_prov.t (Wstat: 5376 Tests: 34 Failed: 21) > Failed tests: 1, 9-18, 25-34 > Non-zero exit status: 21 > > https://travis-ci.org/openssl/openssl/jobs/590874670 > > Test Summary Report > --- > 30-test_evp.t(Wstat: 256 Tests: 19 Failed: 1) > Failed test: 1 > Non-zero exit status: 1 > 30-test_evp_fetch_prov.t (Wstat: 5376 Tests: 34 Failed: 21) > Failed tests: 1, 9-18, 25-34 > Non-zero exit status: 21 > -- Richard Levitte levi...@openssl.org OpenSSL Project http://www.openssl.org/~levitte/
Build failures on master
Hi, since my last commit on master did not build successfully, I checked the CIs. It turned out that a lot of tests are failing, and they have been for quite a while now. https://travis-ci.org/openssl/openssl/builds/590874649?utm_source=github_status&utm_medium=notification Apart from the well known trio boringssl, krb5, and pyca, there are some new failing tests. It would be nice if we could put some effort into fixing them in order to get back to having stable successful builds on master again. The build failures on master also affect the pull request CI builds and if the failure persists, people stop checking their red crosses. Matthias -- https://travis-ci.org/openssl/openssl/jobs/590874663 80-test_ssl_old.t(Wstat: 256 Tests: 6 Failed: 1) Failed test: 3 Non-zero exit status: 1 https://travis-ci.org/openssl/openssl/jobs/590874664 Test Summary Report --- 95-test_external_boringssl.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 95-test_external_krb5.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 95-test_external_pyca.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 https://travis-ci.org/openssl/openssl/jobs/590874669 Test Summary Report --- 30-test_evp.t(Wstat: 256 Tests: 19 Failed: 1) Failed test: 1 Non-zero exit status: 1 30-test_evp_fetch_prov.t (Wstat: 5376 Tests: 34 Failed: 21) Failed tests: 1, 9-18, 25-34 Non-zero exit status: 21 https://travis-ci.org/openssl/openssl/jobs/590874670 Test Summary Report --- 30-test_evp.t(Wstat: 256 Tests: 19 Failed: 1) Failed test: 1 Non-zero exit status: 1 30-test_evp_fetch_prov.t (Wstat: 5376 Tests: 34 Failed: 21) Failed tests: 1, 9-18, 25-34 Non-zero exit status: 21
AW: Reorganization of the header files (GitHub #9333)
It's merged to master. If you encounter merge problems while rebasing, please consult https://github.com/openssl/openssl/pull/9333#issuecomment-536105158 Matthias
AW: Reorganization of the header files (GitHub #9333)
> Go for it, the antipodean contingent aren’t busy this weekend. Ok, since I have green light from three OMC members now, I think there is no need to wait until tomorrow. I'll merge later this evening. Matthias
Re: Reorganization of the header files (GitHub #9333)
Go for it, the antipodean contingent aren’t busy this weekend. Pauli -- Dr Paul Dale | Distinguished Architect | Cryptographic Foundations Phone +61 7 3031 7217 Oracle Australia > On 28 Sep 2019, at 5:05 pm, Dr. Matthias St. Pierre > wrote: > >> Merge early is pretty much my default position ... and that applies to this >> context in my view. > > Thank you Tim for your quick and clear consent. > > Meanwhile, pull request #9333 and its counterpart #9681 for the 1.1.1 stable > branch have been approved by Richard. Unless I hear any protest until Sunday > afternoon (CEST), I would like to merge in the evening, just in time before > the > Australian plumbers start their weekly shift again. > > Matthias
AW: Reorganization of the header files (GitHub #9333)
> Merge early is pretty much my default position ... and that applies to this > context in my view. Thank you Tim for your quick and clear consent. Meanwhile, pull request #9333 and its counterpart #9681 for the 1.1.1 stable branch have been approved by Richard. Unless I hear any protest until Sunday afternoon (CEST), I would like to merge in the evening, just in time before the Australian plumbers start their weekly shift again. Matthias
