Re: Should the return result of CRYPTO_UP_REF() / CRYPTO_DOWN_REF() be checked?

2020-02-10 Thread Bernd Edlinger
On 2/10/20 6:29 PM, Kurt Roeckx wrote: > On Mon, Feb 10, 2020 at 04:19:20PM +, Matt Caswell wrote: >> >> >> On 10/02/2020 00:15, SHANE LONTIS wrote: >>> With the new architecture changes there are quite a few new calls to >>> >>> CRYPTO_UP_REF() >>> CRYPTO_DOWN_REF() >>> >>> These methods

Re: Should the return result of CRYPTO_UP_REF() / CRYPTO_DOWN_REF() be checked?

2020-02-10 Thread Kurt Roeckx
On Mon, Feb 10, 2020 at 04:19:20PM +, Matt Caswell wrote: > > > On 10/02/2020 00:15, SHANE LONTIS wrote: > > With the new architecture changes there are quite a few new calls to > > > > CRYPTO_UP_REF() > > CRYPTO_DOWN_REF() > > > > These methods return an int that is not being checked in

Re: Should the return result of CRYPTO_UP_REF() / CRYPTO_DOWN_REF() be checked?

2020-02-10 Thread Matt Caswell
On 10/02/2020 00:15, SHANE LONTIS wrote: > With the new architecture changes there are quite a few new calls to > > CRYPTO_UP_REF() > CRYPTO_DOWN_REF() > > These methods return an int that is not being checked in lots of places. > > This return value only seems to affect fallback code that

Re: Github PR label automation

2020-02-10 Thread Sam Roberts
I've seen some projects enjoying https://github.com/apps/stale, though its focus is not so much relabelling things that are ready, but closing things that are not active, which might not be relevant here. On Sun, Feb 9, 2020 at 2:23 AM Mark J Cox wrote: > > Okay, I'll leave things as they are