Re: [openssl-project] build/test before merging

2018-05-24 Thread Viktor Dukhovni
> On May 24, 2018, at 4:42 PM, Richard Levitte wrote: > > Those are non-standard and a matter of personal taste. I used those before I > discovered --fixup and --squash. How many variants should we support? > > (I'm not totally against the idea, mind you...) Let's stick with the standard ve

Re: [openssl-project] build/test before merging

2018-05-24 Thread Dr. Matthias St. Pierre
l.org Betreff: Re: [openssl-project] build/test before merging Those are non-standard and a matter of personal taste. I used those before I discovered --fixup and --squash. How many variants should we support? (I'm not totally against the idea, mind you...) Chee

Re: [openssl-project] build/test before merging

2018-05-24 Thread Richard Levitte
che Nachricht- >Von: openssl-project Im Auftrag >von Richard Levitte >Gesendet: Mittwoch, 23. Mai 2018 18:02 >An: openssl-project@openssl.org >Betreff: Re: [openssl-project] build/test before merging > >In message <6d5b206f-a0f1-8b60-fbf5-5f08c7c26...@openssl.org>

Re: [openssl-project] build/test before merging

2018-05-24 Thread Dr. Matthias St. Pierre
--- Von: openssl-project Im Auftrag von Richard Levitte Gesendet: Mittwoch, 23. Mai 2018 18:02 An: openssl-project@openssl.org Betreff: Re: [openssl-project] build/test before merging In message <6d5b206f-a0f1-8b60-fbf5-5f08c7c26...@openssl.org> on Wed, 23 May 2018 16:54:23 +0100, Matt Cas

Re: [openssl-project] build/test before merging

2018-05-23 Thread Richard Levitte
In message <20180523.180148.154491224151456127.levi...@openssl.org> on Wed, 23 May 2018 18:01:48 +0200 (CEST), Richard Levitte said: levitte> In message <6d5b206f-a0f1-8b60-fbf5-5f08c7c26...@openssl.org> on Wed, 23 May 2018 16:54:23 +0100, Matt Caswell said: levitte> levitte> matt> On 23/05/1

Re: [openssl-project] build/test before merging

2018-05-23 Thread Richard Levitte
In message <6d5b206f-a0f1-8b60-fbf5-5f08c7c26...@openssl.org> on Wed, 23 May 2018 16:54:23 +0100, Matt Caswell said: matt> On 23/05/18 16:50, Benjamin Kaduk wrote: matt> > But I am curious if we currently do and/or should have a commit hook matt> > on git.openssl.org to reject commits that start

Re: [openssl-project] build/test before merging

2018-05-23 Thread Matt Caswell
On 23/05/18 16:50, Benjamin Kaduk wrote: > On Wed, May 23, 2018 at 03:12:30PM +, Dr. Matthias St. Pierre wrote: >>> So do you guys use the ghmerge script or own procedures? I'm curious. >> >> At the beginnning, I tried to use ghmerge but it was not flexible >> enough for my needs. In particu

Re: [openssl-project] build/test before merging

2018-05-23 Thread Dr. Matthias St. Pierre
> But I am curious if we currently do and/or should have a commit hook on > git.openssl.org to reject commits that start with "!fixup". We probably don't, but it's a good idea to have it. Matthias ___ openssl-project mailing list openssl-project@opens

Re: [openssl-project] build/test before merging

2018-05-23 Thread Benjamin Kaduk
On Wed, May 23, 2018 at 03:12:30PM +, Dr. Matthias St. Pierre wrote: > > So do you guys use the ghmerge script or own procedures? I'm curious. > > At the beginnning, I tried to use ghmerge but it was not flexible > enough for my needs. In particular, it only gives me the choice > between squa

Re: [openssl-project] build/test before merging

2018-05-23 Thread Dr. Matthias St. Pierre
> +1 for python! :) Well, if this is a "go for it"... ;-) Oh, and I forgot to mention 'ghtool cherry-pick {110,102}' ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project

Re: [openssl-project] build/test before merging

2018-05-23 Thread Salz, Rich
>Unfortunately, I didn't have time to follow my vision yet. Also, it would > have been easier for me to do it in Python than in Perl. +1 for python! :) ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/l

Re: [openssl-project] build/test before merging

2018-05-23 Thread Dr. Matthias St. Pierre
My vision is a more versatile tool (say: ghtool) with separate subcommands as building blocks to simplify common subtasks: ghtool {checkout,rebase,squash,addrev,push} ... This tool could support the concept of a "current pull request" by using a naming convention for the local branches: 'g

Re: [openssl-project] build/test before merging

2018-05-23 Thread Dr. Matthias St. Pierre
> So do you guys use the ghmerge script or own procedures? I'm curious. At the beginnning, I tried to use ghmerge but it was not flexible enough for my needs. In particular, it only gives me the choice between squashing everything or leaving everything as it is. Most notably, it does not suppor

Re: [openssl-project] build/test before merging

2018-05-23 Thread Matt Caswell
On 23/05/18 01:43, Salz, Rich wrote: > > I do the same, but I am reluctant having a script doing it for me using > some fixed recipe... > >>I'm happy doing the build/test manually before merging, too. > > > So do you guys use the ghmerge script or own procedures? I'm curious.

Re: [openssl-project] build/test before merging

2018-05-22 Thread Richard Levitte
In message <25feb2a8-b363-443d-bae8-c47d1ad92...@akamai.com> on Wed, 23 May 2018 00:43:58 +, "Salz, Rich" said: rsalz> > I do the same, but I am reluctant having a script doing it for me using some fixed recipe... rsalz> rsalz> >I'm happy doing the build/test manually before me

Re: [openssl-project] build/test before merging

2018-05-22 Thread Benjamin Kaduk
On Wed, May 23, 2018 at 12:43:58AM +, Salz, Rich wrote: > > I do the same, but I am reluctant having a script doing it for me using > some fixed recipe... > > >I'm happy doing the build/test manually before merging, too. > > > So do you guys use the ghmerge script or own proce

Re: [openssl-project] build/test before merging

2018-05-22 Thread Viktor Dukhovni
> On May 22, 2018, at 8:43 PM, Salz, Rich wrote: > > So do you guys use the ghmerge script or own procedures? I'm curious. Good point, I've not yet had a chance to look at ghmerge and figure out how/whether to use it. If that continues, ... my preferences for its implementation don't carry m

Re: [openssl-project] build/test before merging

2018-05-22 Thread Salz, Rich
> I do the same, but I am reluctant having a script doing it for me using some fixed recipe... >I'm happy doing the build/test manually before merging, too. So do you guys use the ghmerge script or own procedures? I'm curious. ___ open

Re: [openssl-project] build/test before merging

2018-05-22 Thread Benjamin Kaduk
On Tue, May 22, 2018 at 08:39:21PM -0400, Viktor Dukhovni wrote: > > > > On May 22, 2018, at 8:37 PM, Salz, Rich wrote: > > > > No, I'm sure it does not. I think the safer thing is to do a full build, > > to catch things like make update errors, and such. I also run the test > > suite befor

Re: [openssl-project] build/test before merging

2018-05-22 Thread Viktor Dukhovni
> On May 22, 2018, at 8:37 PM, Salz, Rich wrote: > > No, I'm sure it does not. I think the safer thing is to do a full build, to > catch things like make update errors, and such. I also run the test suite > before I submit. I do the same, but I am reluctant having a script doing it for me

Re: [openssl-project] build/test before merging

2018-05-22 Thread Salz, Rich
>It probably does not know how/where I prefer to do builds... No, I'm sure it does not. I think the safer thing is to do a full build, to catch things like make update errors, and such. I also run the test suite before I submit. YMMV. ___ o

Re: [openssl-project] build/test before merging

2018-05-22 Thread Viktor Dukhovni
> On May 21, 2018, at 8:15 AM, Salz, Rich wrote: > > The ghmerge script has a commented-out call to “opensslbuild” to build+test > before submitting. > I would like to enable that, and add either –build or –nobuild flags. > Thoughts? It probably does not know how/where I prefer to do builds

[openssl-project] build/test before merging

2018-05-22 Thread Salz, Rich
The ghmerge script has a commented-out call to “opensslbuild” to build+test before submitting. I would like to enable that, and add either –build or –nobuild flags. Thoughts? ___ openssl-project mailing list openssl-project@openssl.org https://mta.opens