Re: Issues and pull requests are largely getting ignored
On Tue, Mar 26, 2019 at 02:20:28PM +0100, Kurt Roeckx wrote: > On Tue, Mar 26, 2019 at 09:53:22AM +, Matt Caswell wrote: > > > > So the real problem there is a mismatch between the opening rate and the > > closing > > rate, i.e. it is NOT that we are ignoring these issues. I see it more as a > > resource issue - we are seeing issues raised at a greater rate than we have > > resources to handle. > > Or that the resources we do have are spend on the wrong thing. One might, perhaps, try to measure distribution of time between [pull-request/issue] submission and the first comment on it. Consider https://github.com/openssl/openssl/pull/8108 and https://github.com/openssl/openssl/pull/7943 (both submitted by users that are now project members), that have both been open for months and still have no comments! > > I can't do the same analysis for PRs because github doesn't detect properly > > when > > we merge PRs (because we don't use the github facility for doing that). I > > would > > expect to see somewhat similar numbers though. > > The amount of open pull requests has been around 200 for the last > few months, so it seems we can just keep up with that currently, > but it used to be around 100. > > So I think that in general we do not have enough resources to keep up > with both the pull requests and issues. Not if we want to keep up the pace of new development towards the goals for the next major release, I agree. (Not that I am doing much to contribute, myself, at this point -- my AD role in the IETF keeps me quite busy.) -Ben
Re: Issues and pull requests are largely getting ignored
On Tue, Mar 26, 2019 at 09:53:22AM +, Matt Caswell wrote: > > So the real problem there is a mismatch between the opening rate and the > closing > rate, i.e. it is NOT that we are ignoring these issues. I see it more as a > resource issue - we are seeing issues raised at a greater rate than we have > resources to handle. Or that the resources we do have are spend on the wrong thing. > I can't do the same analysis for PRs because github doesn't detect properly > when > we merge PRs (because we don't use the github facility for doing that). I > would > expect to see somewhat similar numbers though. The amount of open pull requests has been around 200 for the last few months, so it seems we can just keep up with that currently, but it used to be around 100. So I think that in general we do not have enough resources to keep up with both the pull requests and issues. Kurt
Re: Issues and pull requests are largely getting ignored
I agree with Matt. He and Richard are doing a great job but cannot quite keep up. They are doing a fantastic job given the time available to them. I’ve been a bit slack the last two weeks and will be so for the next four or so but I’ll attempt to catch up. Pauli -- Dr Paul Dale | Cryptographer | Network Security & Encryption Phone +61 7 3031 7217 Oracle Australia > On 26 Mar 2019, at 7:53 pm, Matt Caswell wrote: > > > > On 25/03/2019 20:10, Matthew Lindner wrote: >> Hello OpenSSL Team, >> >> The issues and pull requests on github are largely getting ignored, I >> know the team is busy on the new release but please spend some time on >> these as well. > > I don't think this is a fair characterisation. I see all posts to issues and > PRs > in github for openssl and I see *lots* of activity. > > If I use the github "insights" page I see that over the last month 67 new > issues > were raised and 46 were closed. However those numbers are skewed by issues in > very recent days (its shortly after a weekend and neither Richard or myself > were > around yesterday). Over the last week 23 new issues were raised and 8 were > closed. Subtracting one from the other I see that for the period 1 week ago > to 1 > month ago 44 new issues were raised and 38 were closed. > > So the real problem there is a mismatch between the opening rate and the > closing > rate, i.e. it is NOT that we are ignoring these issues. I see it more as a > resource issue - we are seeing issues raised at a greater rate than we have > resources to handle. The best answer to that IMO is to somehow encourage a > greater participation from the community in helping us to keep on top of these > things. Not sure how best to achieve that though. > > I can't do the same analysis for PRs because github doesn't detect properly > when > we merge PRs (because we don't use the github facility for doing that). I > would > expect to see somewhat similar numbers though. > > > Matt
Re: Issues and pull requests are largely getting ignored
On 25/03/2019 20:10, Matthew Lindner wrote: > Hello OpenSSL Team, > > The issues and pull requests on github are largely getting ignored, I > know the team is busy on the new release but please spend some time on > these as well. I don't think this is a fair characterisation. I see all posts to issues and PRs in github for openssl and I see *lots* of activity. If I use the github "insights" page I see that over the last month 67 new issues were raised and 46 were closed. However those numbers are skewed by issues in very recent days (its shortly after a weekend and neither Richard or myself were around yesterday). Over the last week 23 new issues were raised and 8 were closed. Subtracting one from the other I see that for the period 1 week ago to 1 month ago 44 new issues were raised and 38 were closed. So the real problem there is a mismatch between the opening rate and the closing rate, i.e. it is NOT that we are ignoring these issues. I see it more as a resource issue - we are seeing issues raised at a greater rate than we have resources to handle. The best answer to that IMO is to somehow encourage a greater participation from the community in helping us to keep on top of these things. Not sure how best to achieve that though. I can't do the same analysis for PRs because github doesn't detect properly when we merge PRs (because we don't use the github facility for doing that). I would expect to see somewhat similar numbers though. Matt
AW: Issues and pull requests are largely getting ignored
> > Hello OpenSSL Team, > > > > The issues and pull requests on github are largely getting ignored, I > > know the team is busy on the new release but please spend some time on > > these as well. And I forgot to say: you are right, thanks for the polite reminder :-)
AW: Issues and pull requests are largely getting ignored
Hi Matthew, please feel free to post the single word "ping" to the pull requests for which you would like to regain attention. These reminders are welcome (if they are not abused too much :-) ). Regards, Matthias > -Ursprüngliche Nachricht- > Von: openssl-project Im Auftrag von > Matthew Lindner > Gesendet: Montag, 25. März 2019 21:11 > An: openssl-project@openssl.org > Betreff: Issues and pull requests are largely getting ignored > > Hello OpenSSL Team, > > The issues and pull requests on github are largely getting ignored, I > know the team is busy on the new release but please spend some time on > these as well. > > Thank you, > Matthew Lindner
Issues and pull requests are largely getting ignored
Hello OpenSSL Team, The issues and pull requests on github are largely getting ignored, I know the team is busy on the new release but please spend some time on these as well. Thank you, Matthew Lindner