Re: New GitHub label for release blockers
Concerning PR #4930: Originally that PR was about extending support for PKCS#12 input in apps, which meanwhile has been superseded mostly by OSSL_STORE. I meanwhile carved out the most interesting remaining pieces of the PR and contributed them separately. I've just rebased and cleaned up the various remaining commits. What is still left are fixes for several corner cases in PKCS#12 input and its error handling. There are also some rather unrelated fixes to several apps and their documentation, which I could separate if requested. I don't think any of this is critical before the beta release; in particular there are no feature or API changes any more. David On 14.09.20 19:32, Richard Levitte wrote: > On Sun, 13 Sep 2020 22:41:23 +0200, > Dr. Matthias St. Pierre wrote: >> Conversely, there were also pull requests associated with the '3.0.0' or >> '3.0.0 beta1' milestone, >> without being associated to the '3.0 New Core + FIPS' project. This has >> been fixed now. > I fail to see why the milestones '3.0.0' / '3.0.0 beta1' must be 1:1 > with the '3.0 New Core + FIPS' project. If we make them the same, > what's the reason to have both? > > I just looked in the project, and these are issues and PRs the > presence of which I think is questionable: > > #10612 > #4930 > #12860 > #11311 > > Maybe there's a misunderstand of what "3.0 New Core" means. Please > note the lack of comma. But if that doesn't help, how about the > project description? > > I've seen a bit too much of wanting to pile *everything* into that > project. That was never the intention. > > Cheers, > Richard >
RE: New GitHub label for release blockers
> I fail to see why the milestones '3.0.0' / '3.0.0 beta1' must be 1:1 > with the '3.0 New Core + FIPS' project. Sorry for the misunderstanding, Richard. I did not intend to mess around with your project organization. Since it was the only active GitHub project, I misinterpreted it as the "3.0.0" project and did not read the fine print. All I intended to do is to obtain an accurate overwiew of what remains to be done. Because listing them on the otc mailing list is not very maintainable, and the google spreadsheet is not viewable by the public. > If we make them the same, what's the reason to have both? I completely agree. According to my understanding, it would have made more sense if we had created an "OpenSSL 3.0" project for managing all what needs to go into this major release and three milestones '3.0.0 alpha', '3.0.0 beta', '3.0.0' associated with the major events. Regards, Matthias
Re: New GitHub label for release blockers
On Sun, 13 Sep 2020 22:41:23 +0200, Dr. Matthias St. Pierre wrote: > > Conversely, there were also pull requests associated with the '3.0.0' or > '3.0.0 beta1' milestone, > without being associated to the '3.0 New Core + FIPS' project. This has > been fixed now. I fail to see why the milestones '3.0.0' / '3.0.0 beta1' must be 1:1 with the '3.0 New Core + FIPS' project. If we make them the same, what's the reason to have both? I just looked in the project, and these are issues and PRs the presence of which I think is questionable: #10612 #4930 #12860 #11311 Maybe there's a misunderstand of what "3.0 New Core" means. Please note the lack of comma. But if that doesn't help, how about the project description? I've seen a bit too much of wanting to pile *everything* into that project. That was never the intention. Cheers, Richard -- Richard Levitte levi...@openssl.org OpenSSL Project http://www.openssl.org/~levitte/
Re: New GitHub label for release blockers
> BTW: It took me all my force of will to resist the temptation of making a pun > by naming the label [urgent: beta blocker]. Failed you have. Your training is not yet compete :) Pauli -- Dr Paul Dale | Distinguished Architect | Cryptographic Foundations Phone +61 7 3031 7217 Oracle Australia
RE: New GitHub label for release blockers
Conversely, there were also pull requests associated with the '3.0.0' or '3.0.0 beta1' milestone, without being associated to the '3.0 New Core + FIPS' project. This has been fixed now.
RE: New GitHub label for release blockers
> when your time permits, could you please double-check whether all important > tickets > for beta1 were moved correctly from '3.0.0' to '3.0.0 beta1'? The '3.0 New Core + FIPS' project currently lists 21 open pull requests, [is:open is:pr project:openssl/openssl/2]: https://github.com/openssl/openssl/pulls?q=is%3Aopen+is%3Apr+project%3Aopenssl%2Fopenssl%2F2+ ten of which are not associated with any milestone yet [is:open is:pr project:openssl/openssl/2 no:milestone]: https://github.com/openssl/openssl/pulls?q=is%3Aopen+is%3Apr+project%3Aopenssl%2Fopenssl%2F2+no%3Amilestone It would be helpful if someone of the core team could check and assigne them. Matthias
RE: New GitHub label for release blockers
That's a very nice summary, Matt. when your time permits, could you please double-check whether all important tickets for beta1 were moved correctly from '3.0.0' to '3.0.0 beta1'? Thanks, Matthias
Re: New GitHub label for release blockers
On 13/09/2020 15:16, Nicola Tuveri wrote: > ... I still have very confused ideas regarding the "best" conventional > usage of github features like labels, milestones and projects: I read > the official documentation about them and I grasp the general ideas > behind them, but too often the boundaries are too foggy for me to > navigate and pick the right tool for the job in a consistent and organic > manner. In my head I think of them like this: - A label: describes a characteristic of a PR/issue - A milestone: a time based goal (such as a specific release) - A project: A collection of PRs/issues related by some common long term objective There is some confusion between labels and milestones, because you could think of "a time based goal" set for a pr/issue as a characteristic of it. So you could use either for the purpose. However since github has both, it seems more appropriate to use a milestone when talking about a time based goal since it is the more specific concept. Matt > > Nicola > > On Sun, Sep 13, 2020, 17:01 Dr. Matthias St. Pierre > mailto:matthias.st.pie...@ncp-e.com>> wrote: > > Nicola suggested and convinced me, that it would be better to have a > dedicated > milestone for the 3.0.0 beta1 release instead of adding a new label. > > So here it is, I already added all the tickets with the release > blocker label and will > remove the label again. > > https://github.com/openssl/openssl/milestone/17 > > Matthias > > > > > -Original Message- > > From: Dr. Matthias St. Pierre > > Sent: Sunday, September 13, 2020 3:17 PM > > To: openssl-project@openssl.org <mailto:openssl-project@openssl.org> > > Subject: New GitHub label for release blockers > > > > Hi all, > > > > taking up again the discussion from openssl-project where I > suggested to (ab)use > > the 3.0.0 milestone for release blockers, (see link and citation > at the end of the mail), > > I propose to add a new label for this purpose instead. In fact, I > already created the label > > > > [urgent: release blocker] (see link below) > > > > and will add the mentioned tickets within shortly. So you can take > a look and tell > > me whether you like it or not. (If not, no problem. I'll just > delete the label again.) > > > > Matthias > > > > > > BTW: It took me all my force of will to resist the temptation of > making a pun > > by naming the label [urgent: beta blocker]. > > > > > > References: > > == > > > > [urgent: release blocker]: > > > https://github.com/openssl/openssl/labels/urgent%3A%20release%20blocker > > > > [openssl-project message]: > > > > https://mta.openssl.org/pipermail/openssl-project/2020-September/002191.html > > > > > > > > > For a more accurate and timely public overview over the > current state of the blockers, > > > > > it might be helpful to manage them via the 3.0.0 milestone > > > > > > > > > > https://github.com/openssl/openssl/milestone/15 > > > > > > > > > > Some of the tickets listed below were already associated to > the milestone, the others > > > > > were added by me now. > > > > > > > > I think the 3.0.0 milestone is what we expect to be in the > > > > 3.0.0 release, not the beta release. That is bug fixes don't need > > > > to be in the beta release, but if it adds new functionallity it > > > > needs to be in the beta release. > > > > > > I was aware of this subtlety but I thought that we just could > (ab-)use the milestone for > > > the beta1 release and reuse it later for the final release, > instead of creating a new milestone. > > > > > > Practically all of the relevant PRs are associated to the [3.0 > New Core + FIPS] GitHub Project > > > anyway, so it would be possible to remove the post-beta PRs from > the milestone and restore > > > them later. (In my mind, I see project managers running away > screeming...) > > > > > > Matthias > > > > > > > > > [3.0 New Core + FIPS]: > https://github.com/openssl/openssl/projects/2 >
Re: New GitHub label for release blockers
I was not referring to this page in particular, but in general to the various pages on github doc (and more in general among the first Google results) about github labels and milestones and how to use them. There seem to be, in the wild, different documented approaches, probably even influenced by the introduction over time of milestones and ways of using labels and milestones. I think having a common understanding of how we want to use these tools is a good idea, so I definitely welcome the proposition of talking about it during the vf2f! Nicola On Sun, Sep 13, 2020, 17:26 Dr. Matthias St. Pierre < matthias.st.pie...@ncp-e.com> wrote: > Since we were able to collect some experiences working on the ‘3.0 New > Core + FIPS’ project, I think that’s a perfect subject > to be discussed on the face-to-face meeting. I will add it to the list of > proposed topics. As for the official documentation you > mentioned, are you talking about this one? > https://github.com/features/project-management > > Matthias > > > From: Nicola Tuveri > Sent: Sunday, September 13, 2020 4:17 PM > To: Dr. Matthias St. Pierre > Cc: openssl-project@openssl.org > Subject: Re: New GitHub label for release blockers > > Matthias overcredits me: I just wanted to know his opinion about when we > should use labels and when milestones (and that is why I wrote to him > off-list, as a very confused and shy pupil asking a sensei for wisdom > pearls). > > All the alleged convincing was self-inflicted :P > > > And now that my ignorance is out of the closet... > ... I still have very confused ideas regarding the "best" conventional > usage of github features like labels, milestones and projects: I read the > official documentation about them and I grasp the general ideas behind > them, but too often the boundaries are too foggy for me to navigate and > pick the right tool for the job in a consistent and organic manner. > > Nicola >
RE: New GitHub label for release blockers
Since we were able to collect some experiences working on the ‘3.0 New Core + FIPS’ project, I think that’s a perfect subject to be discussed on the face-to-face meeting. I will add it to the list of proposed topics. As for the official documentation you mentioned, are you talking about this one? https://github.com/features/project-management Matthias From: Nicola Tuveri Sent: Sunday, September 13, 2020 4:17 PM To: Dr. Matthias St. Pierre Cc: openssl-project@openssl.org Subject: Re: New GitHub label for release blockers Matthias overcredits me: I just wanted to know his opinion about when we should use labels and when milestones (and that is why I wrote to him off-list, as a very confused and shy pupil asking a sensei for wisdom pearls). All the alleged convincing was self-inflicted :P And now that my ignorance is out of the closet... ... I still have very confused ideas regarding the "best" conventional usage of github features like labels, milestones and projects: I read the official documentation about them and I grasp the general ideas behind them, but too often the boundaries are too foggy for me to navigate and pick the right tool for the job in a consistent and organic manner. Nicola
Re: New GitHub label for release blockers
Matthias overcredits me: I just wanted to know his opinion about when we should use labels and when milestones (and that is why I wrote to him off-list, as a very confused and shy pupil asking a sensei for wisdom pearls). All the alleged convincing was self-inflicted :P And now that my ignorance is out of the closet... ... I still have very confused ideas regarding the "best" conventional usage of github features like labels, milestones and projects: I read the official documentation about them and I grasp the general ideas behind them, but too often the boundaries are too foggy for me to navigate and pick the right tool for the job in a consistent and organic manner. Nicola On Sun, Sep 13, 2020, 17:01 Dr. Matthias St. Pierre < matthias.st.pie...@ncp-e.com> wrote: > Nicola suggested and convinced me, that it would be better to have a > dedicated > milestone for the 3.0.0 beta1 release instead of adding a new label. > > So here it is, I already added all the tickets with the release blocker > label and will > remove the label again. > > https://github.com/openssl/openssl/milestone/17 > > Matthias > > > > > -Original Message- > > From: Dr. Matthias St. Pierre > > Sent: Sunday, September 13, 2020 3:17 PM > > To: openssl-project@openssl.org > > Subject: New GitHub label for release blockers > > > > Hi all, > > > > taking up again the discussion from openssl-project where I suggested to > (ab)use > > the 3.0.0 milestone for release blockers, (see link and citation at the > end of the mail), > > I propose to add a new label for this purpose instead. In fact, I > already created the label > > > > [urgent: release blocker] (see link below) > > > > and will add the mentioned tickets within shortly. So you can take a > look and tell > > me whether you like it or not. (If not, no problem. I'll just delete the > label again.) > > > > Matthias > > > > > > BTW: It took me all my force of will to resist the temptation of making > a pun > > by naming the label [urgent: beta blocker]. > > > > > > References: > > == > > > > [urgent: release blocker]: > > > https://github.com/openssl/openssl/labels/urgent%3A%20release%20blocker > > > > [openssl-project message]: > > > https://mta.openssl.org/pipermail/openssl-project/2020-September/002191.html > > > > > > > > > For a more accurate and timely public overview over the current > state of the blockers, > > > > > it might be helpful to manage them via the 3.0.0 milestone > > > > > > > > > > https://github.com/openssl/openssl/milestone/15 > > > > > > > > > > Some of the tickets listed below were already associated to the > milestone, the others > > > > > were added by me now. > > > > > > > > I think the 3.0.0 milestone is what we expect to be in the > > > > 3.0.0 release, not the beta release. That is bug fixes don't need > > > > to be in the beta release, but if it adds new functionallity it > > > > needs to be in the beta release. > > > > > > I was aware of this subtlety but I thought that we just could (ab-)use > the milestone for > > > the beta1 release and reuse it later for the final release, instead of > creating a new milestone. > > > > > > Practically all of the relevant PRs are associated to the [3.0 New > Core + FIPS] GitHub Project > > > anyway, so it would be possible to remove the post-beta PRs from the > milestone and restore > > > them later. (In my mind, I see project managers running away > screeming...) > > > > > > Matthias > > > > > > > > > [3.0 New Core + FIPS]: https://github.com/openssl/openssl/projects/2 > >
RE: New GitHub label for release blockers
I added some issues mentioned in the 'Beta1 PR deadline' thread to the new label. Feel free to extend and modify the list as necessary.
New GitHub label for release blockers
Hi all, taking up again the discussion from openssl-project where I suggested to (ab)use the 3.0.0 milestone for release blockers, (see link and citation at the end of the mail), I propose to add a new label for this purpose instead. In fact, I already created the label [urgent: release blocker] (see link below) and will add the mentioned tickets within shortly. So you can take a look and tell me whether you like it or not. (If not, no problem. I'll just delete the label again.) Matthias BTW: It took me all my force of will to resist the temptation of making a pun by naming the label [urgent: beta blocker]. References: == [urgent: release blocker]: https://github.com/openssl/openssl/labels/urgent%3A%20release%20blocker [openssl-project message]: https://mta.openssl.org/pipermail/openssl-project/2020-September/002191.html > > > For a more accurate and timely public overview over the current state of > > > the blockers, > > > it might be helpful to manage them via the 3.0.0 milestone > > > > > > https://github.com/openssl/openssl/milestone/15 > > > > > > Some of the tickets listed below were already associated to the > > > milestone, the others > > > were added by me now. > > > > I think the 3.0.0 milestone is what we expect to be in the > > 3.0.0 release, not the beta release. That is bug fixes don't need > > to be in the beta release, but if it adds new functionallity it > > needs to be in the beta release. > > I was aware of this subtlety but I thought that we just could (ab-)use the > milestone for > the beta1 release and reuse it later for the final release, instead of > creating a new milestone. > > Practically all of the relevant PRs are associated to the [3.0 New Core + > FIPS] GitHub Project > anyway, so it would be possible to remove the post-beta PRs from the > milestone and restore > them later. (In my mind, I see project managers running away screeming...) > > Matthias > > > [3.0 New Core + FIPS]: https://github.com/openssl/openssl/projects/2
