Re: Some more extra tests
Dear Nicola, Please see https://github.com/openssl/openssl/pull/11792 It currently does not enable TCL and Perl tests, but the C tests also helped me to find regression in the master branch. On Thu, May 7, 2020 at 10:55 PM Dmitry Belyavsky wrote: > Dear Nicola, > > I feel a significant lack of knowledge of preparing such a PR. > If I was able to submit it, I would. > > On Thu, May 7, 2020 at 10:38 PM Nicola Tuveri wrote: > >> I would be interested in seeing a PR to see what enabling these tests >> would require! >> >> I believe we do indeed need to test more thoroughly to ensure we are not >> breaking the engine API! >> >> >> Nicola >> >> On Thu, May 7, 2020, 21:08 Dmitry Belyavsky wrote: >> >>> Dear colleagues, >>> >>> Let me draw your attention to a potentially reasonable set of extended >>> tests for the openssl engines. >>> >>> The gost-engine project (https://github.com/gost-engine/engine) has >>> some test scenarios robust enough for testing engine-provided algorithms >>> and some basic RSA regression tests. It contains a rather eclectic set of >>> C, Perl, and TCL(!) tests that are used by me on a regular basis. >>> >>> If these tests are included in the project extended test suite, they >>> could reduce some regression that sometimes occurs (see >>> https://github.com/gost-engine/engine/issues/232 as a current list of >>> known problems). >>> >>> I will be happy to assist in enabling these tests as a part of openssl >>> test suites. >>> Many thanks! >>> >>> -- >>> SY, Dmitry Belyavsky >>> >> > > -- > SY, Dmitry Belyavsky > -- SY, Dmitry Belyavsky
Re: Some more extra tests
Dear Nicola, I feel a significant lack of knowledge of preparing such a PR. If I was able to submit it, I would. On Thu, May 7, 2020 at 10:38 PM Nicola Tuveri wrote: > I would be interested in seeing a PR to see what enabling these tests > would require! > > I believe we do indeed need to test more thoroughly to ensure we are not > breaking the engine API! > > > Nicola > > On Thu, May 7, 2020, 21:08 Dmitry Belyavsky wrote: > >> Dear colleagues, >> >> Let me draw your attention to a potentially reasonable set of extended >> tests for the openssl engines. >> >> The gost-engine project (https://github.com/gost-engine/engine) has some >> test scenarios robust enough for testing engine-provided algorithms and >> some basic RSA regression tests. It contains a rather eclectic set of C, >> Perl, and TCL(!) tests that are used by me on a regular basis. >> >> If these tests are included in the project extended test suite, they >> could reduce some regression that sometimes occurs (see >> https://github.com/gost-engine/engine/issues/232 as a current list of >> known problems). >> >> I will be happy to assist in enabling these tests as a part of openssl >> test suites. >> Many thanks! >> >> -- >> SY, Dmitry Belyavsky >> > -- SY, Dmitry Belyavsky
Re: Some more extra tests
I would be interested in seeing a PR to see what enabling these tests would require! I believe we do indeed need to test more thoroughly to ensure we are not breaking the engine API! Nicola On Thu, May 7, 2020, 21:08 Dmitry Belyavsky wrote: > Dear colleagues, > > Let me draw your attention to a potentially reasonable set of extended > tests for the openssl engines. > > The gost-engine project (https://github.com/gost-engine/engine) has some > test scenarios robust enough for testing engine-provided algorithms and > some basic RSA regression tests. It contains a rather eclectic set of C, > Perl, and TCL(!) tests that are used by me on a regular basis. > > If these tests are included in the project extended test suite, they could > reduce some regression that sometimes occurs (see > https://github.com/gost-engine/engine/issues/232 as a current list of > known problems). > > I will be happy to assist in enabling these tests as a part of openssl > test suites. > Many thanks! > > -- > SY, Dmitry Belyavsky >
Some more extra tests
Dear colleagues, Let me draw your attention to a potentially reasonable set of extended tests for the openssl engines. The gost-engine project (https://github.com/gost-engine/engine) has some test scenarios robust enough for testing engine-provided algorithms and some basic RSA regression tests. It contains a rather eclectic set of C, Perl, and TCL(!) tests that are used by me on a regular basis. If these tests are included in the project extended test suite, they could reduce some regression that sometimes occurs (see https://github.com/gost-engine/engine/issues/232 as a current list of known problems). I will be happy to assist in enabling these tests as a part of openssl test suites. Many thanks! -- SY, Dmitry Belyavsky