Re: Stale PR stats @Jun01

[Mark J Cox]

Rich Salz mailed me about the issues that were in the "waiting for
reporter" state in my summary noting that some of them shouldn't be in
that state.  I investigated just now and made some changes to my
script, so if you are a reviewer or reporter you may get some extra
pings today as things moved to the right state.

The script looked at the github timeline 'reviewed' events, however
those events only happen when changes are requested or the review is
approved or rejected.  So if a reporter does an update and re-requests
a review, it still shows up for the script in state
"changes_requested" which isn't true.  So now the script also looks at
"review_requested" events, and a "review_requested" will change the
state from "changes_requested".

When looking through the list one by one I spotted quite a few PRs
which had changes_requested but where the reporter had made some
changes or commented about the changes but had not re-requested a
review.  I manually did that re-request.

I'll also add a OpenSSL Machine comment to stale "changes_requested"
state issues to remind the reporter to do that action (and to be sure
to re-request a review once they have done so).

So here was the state before:

>  waiting for reporter  ( 16 issues, median  299.5  days)
>
> 11530 branch: 1.1.1, branch: master, cla: trivial,
> reviewed:changes_requested days:46
> 11514 reviewed:changes_requested days:50
> 11310 reviewed:changes_requested days:74
> 10724 reviewed:changes_requested days:37
> 10590 reviewed:changes_requested days:146
> 9575 reviewed:changes_requested days:293
> 9461 reviewed:changes_requested days:306
> 9427 reviewed:changes_requested days:313
> 9243 reviewed:changes_requested days:315
> 9240 reviewed:changes_requested days:340
> 8992 reviewed:changes_requested days:257
> 8962 reviewed:changes_requested days:75
> 8730 reviewed:changes_requested days:354
> 8674 reviewed:changes_requested days:409
> 7961 reviewed:changes_requested days:511
> 7432 reviewed:changes_requested days:590
>
>  waiting for review  ( 2 issues, median  40.5  days)
>
> 11526 approval: review pending, branch: 1.1.1, branch: master,
> reviewed:approved days:32
> 11278 approval: review pending, branch: master, reviewed:commented days:49

And now it is:

 waiting for reporter  ( 9 issues, median  308  days)

11530 branch: 1.1.1, branch: master, cla: trivial,
reviewed:changes_requested days:48
10590 reviewed:changes_requested days:148
9575 reviewed:changes_requested days:294
9461 reviewed:changes_requested days:308
9427 reviewed:changes_requested days:315
8962 reviewed:changes_requested days:76
8674 reviewed:changes_requested days:411
7961 reviewed:changes_requested days:513
7432 reviewed:changes_requested days:592

 waiting for review  ( 8 issues, median  51.5  days)

11526 approval: review pending, branch: 1.1.1, branch: master,
reviewed:approved days:34
11514 reviewed:review pending days:52
11278 approval: review pending, branch: master, reviewed:commented days:51
10724 reviewed:review pending days:38
10632 reviewed:review pending days:35
8992 reviewed:review pending days:258
8730 reviewed:review pending days:356
6725 milestone:Assessed, reviewed:review pending days:363

Stale PR stats @Jun01

[Mark J Cox]

In April I started a script to ping stale PRs that were in certain
states.  The script has also been collecting statistics (trending and
snapshot).  I intend to post this monthly and after a few months with
trends and commentary.

PRs that have not had any updates in the last 30 days and are not WIP:

all  ( 158 issues, median  219  days) of which:

 failed CI  ( 28 issues, median  114.0  days)
 deferred after 1.1.1  ( 40 issues, median  219.0  days)
 cla required  ( 18 issues, median  442.0  days)
 waiting for reporter  ( 16 issues, median  299.5  days)
 waiting for review  ( 2 issues, median  40.5  days)
 waiting for OMC  ( 3 issues, median  83  days)
 waiting for OTC  ( 3 issues, median  55  days)
 all other  ( 48 issues, median  215.0  days)

So, ignoring deferred issues too you could summarise this as:

 Stale PRs waiting for us to do something: 36 (last months: 27,29)
 Stale PRs waiting for the reporter to do something: 34 (last months: 34,37)
 Stale PRs with unclear next action: 48 (last months: 46,42)

There really shouldn't be anything "waiting for OMC/OTC/review" that
is over 30 days; many of these did get a decision and the state just
isn't updated.

Over time I hope we can triage the "all other" PRs with labels so we
know what the next action is on each one.

Details:

 waiting for reporter  ( 16 issues, median  299.5  days)

11530 branch: 1.1.1, branch: master, cla: trivial,
reviewed:changes_requested days:46
11514 reviewed:changes_requested days:50
11310 reviewed:changes_requested days:74
10724 reviewed:changes_requested days:37
10590 reviewed:changes_requested days:146
9575 reviewed:changes_requested days:293
9461 reviewed:changes_requested days:306
9427 reviewed:changes_requested days:313
9243 reviewed:changes_requested days:315
9240 reviewed:changes_requested days:340
8992 reviewed:changes_requested days:257
8962 reviewed:changes_requested days:75
8730 reviewed:changes_requested days:354
8674 reviewed:changes_requested days:409
7961 reviewed:changes_requested days:511
7432 reviewed:changes_requested days:590

 waiting for OMC  ( 3 issues, median  83  days)

10786 approval: done, branch: 1.1.1, branch: master, hold: need
omc decision, reviewed:approved days:83
10195 branch: master, hold: need omc decision, reviewed:commented days:203
5909 hold: need omc decision, milestone:Assessed,
reviewed:changes_requested days:34

 waiting for OTC  ( 3 issues, median  55  days)

9654 approval: otc review pending, branch: master, triaged:
feature, reviewed:changes_requested days:55
9537 approval: otc review pending, hold: cla required,
reviewed:commented days:47
8300 approval: otc review pending, branch: 1.1.1, branch: master,
hold: need otc decision, reviewed:approved days:115

 waiting for review  ( 2 issues, median  40.5  days)

11526 approval: review pending, branch: 1.1.1, branch: master,
reviewed:approved days:32
11278 approval: review pending, branch: master, reviewed:commented days:49

 all other  ( 48 issues, median  215.0  days)

11679  days:87
11545  days:47
11421  days:41
11398 approval: done, branch: master, reviewed:approved days:66
11359  days:46
11341  days:44
11312  days:78
11277 resolved: not a bug,  days:81
11260 reviewed:commented days:86
6  days:48
5  days:87
11057  days:111
10884  days:133
10818  days:139
10570 reviewed:commented days:155
10541  days:170
10338 reviewed:commented days:210
10320 branch: 1.1.1, branch: master, reviewed:commented days:201
10298  days:214
10268  days:216
9655  days:188
9554  days:297
9444 branch: master, reviewed:commented days:41
9421 branch: 1.1.1, branch: master, reviewed:approved days:152
9223 branch: master, reviewed:commented days:114
9206  days:345
9051 reviewed:commented days:208
8956  days:367
8920  days:244
8908  days:382
8862  days:361
8835  days:401
8743 branch: master,  days:412
8668  days:423
8455  days:425
8420  days:426
8333  days:461
8309 branch: master, reviewed:commented days:347
7688  days:547
7615  days:551
7454 reviewed:commented days:502
7274 reviewed:approved days:353
7225 reviewed:commented days:618
6725 milestone:Assessed, reviewed:approved days:361
6518 milestone:Assessed, reviewed:approved days:712
6448 milestone:Assessed,  days:219
6219 milestone:Assessed, reviewed:approved days:750
4487 milestone:Assessed,  days:689