Re: [openssl-project] Issues review

2018-01-24 Thread Matt Caswell
I have now also reviewed the PRs. We currently have 144 PRs open: PRs against 1.0.2: 6 PRs against 1.1.0: 7 PRs against 1.1.1: 55 PRs against 1.2.0: 9 PRs against Post 1.1.1: 63 PRs against Other: 2 I was quite strict about allocating PRs to a milestone. This might mean that some of those decisio

Re: [openssl-project] Issues review

2018-01-23 Thread Benjamin Kaduk
On Tue, Jan 23, 2018 at 11:20:20PM +, Matt Caswell wrote: > > > On 23/01/18 20:55, Benjamin Kaduk wrote: > > On Tue, Jan 23, 2018 at 06:11:50PM +, Matt Caswell wrote: > >> > >> > >> 1.1.0 and 1.0.2 are still supported so issues against those milestones > >> are still relevant. They are *n

Re: [openssl-project] Issues review

2018-01-23 Thread Matt Caswell
On 23/01/18 20:55, Benjamin Kaduk wrote: > On Tue, Jan 23, 2018 at 06:11:50PM +, Matt Caswell wrote: >> >> >> On 23/01/18 18:05, Benjamin Kaduk wrote: >>> On Tue, Jan 23, 2018 at 05:51:41PM +, Matt Caswell wrote: On 23/01/18 17:49, Matt Caswell wrote: > I completed my f

Re: [openssl-project] Issues review

2018-01-23 Thread Benjamin Kaduk
On Tue, Jan 23, 2018 at 06:11:50PM +, Matt Caswell wrote: > > > On 23/01/18 18:05, Benjamin Kaduk wrote: > > On Tue, Jan 23, 2018 at 05:51:41PM +, Matt Caswell wrote: > >> > >> > >> On 23/01/18 17:49, Matt Caswell wrote: > >>> I completed my first pass review of all issues. I still need t

Re: [openssl-project] Issues review

2018-01-23 Thread Matt Caswell
On 23/01/18 18:05, Benjamin Kaduk wrote: > On Tue, Jan 23, 2018 at 05:51:41PM +, Matt Caswell wrote: >> >> >> On 23/01/18 17:49, Matt Caswell wrote: >>> I completed my first pass review of all issues. I still need to look at >>> PRs. I have put all PRs against a milestone using the following

Re: [openssl-project] Issues review

2018-01-23 Thread Benjamin Kaduk
On Tue, Jan 23, 2018 at 05:51:41PM +, Matt Caswell wrote: > > > On 23/01/18 17:49, Matt Caswell wrote: > > I completed my first pass review of all issues. I still need to look at > > PRs. I have put all PRs against a milestone using the following criteria: > > I have put all *issues* against

Re: [openssl-project] Issues review

2018-01-23 Thread Salz, Rich
I reviewed all PR’s and issues that have FIPS in the text and closed most of them as not relevant. On 1/23/18, 12:51 PM, "Matt Caswell" wrote: On 23/01/18 17:49, Matt Caswell wrote: > I completed my first pass review of all issues. I still need to look at > PRs. I have put

Re: [openssl-project] Issues review

2018-01-23 Thread Matt Caswell
On 23/01/18 17:49, Matt Caswell wrote: > I completed my first pass review of all issues. I still need to look at > PRs. I have put all PRs against a milestone using the following criteria: I have put all *issues* against a milestone not PR!! > > If it only applies to 1.0.2 or below: 1.0.2 mile

[openssl-project] Issues review

2018-01-23 Thread Matt Caswell
I completed my first pass review of all issues. I still need to look at PRs. I have put all PRs against a milestone using the following criteria: If it only applies to 1.0.2 or below: 1.0.2 milestone If it only applies to 1.1.0 or below: 1.1.0 milesone If it's API/ABI breaking to fix: 1.2.0 milest