Re: Re-requesting reviews on GitHub

2019-10-30 Thread Matthias St. Pierre 




On 30.10.19 10:14, Richard Levitte wrote:

This is a good idea, and also a detectable event for a bot to listen to.


Sounds like an excellent idea: If approvals and dismissals of approvals
(resp. re-review requests) are all bot events, then the bot should be able
to handle most state changes automatically, including the determination
whether a normal or an omc review is required.  This would be a great
ease for the reviewer's workflow.

Matthias

Re: Re-requesting reviews on GitHub

2019-10-30 Thread Patrick Steuer 

I think its a good idea.

It would prevent issues like
https://github.com/openssl/openssl/pull/9501

Patrick

Re: Re-requesting reviews on GitHub

2019-10-30 Thread Richard Levitte 
This is a good idea, and also a detectable event for a bot to listen to.

Cheers
Richard 

"Dr. Matthias St. Pierre"  skrev: (30 oktober 
2019 09:30:11 CET)
>> Independently of the new 'approval: *' state labelling I was
>wondering whether it wouldn't
>> be a good idea to adopt the habit of explicitly requesting a
>re-review from the other reviewers
>> after significant changes, using the mechanism provided by GitHub
>(i.e. the button with the two
>
>To be more precise: not all reviews need to be invalidated by
>requesting a re-review, only the approvals.

-- 
Skickat från min Android-enhet med K-9 Mail. Ursäkta min fåordighet.

AW: Re-requesting reviews on GitHub

2019-10-30 Thread Dr. Matthias St. Pierre 
> Independently of the new 'approval: *' state labelling I was wondering 
> whether it wouldn't
> be a good idea to adopt the habit of explicitly requesting a re-review from 
> the other reviewers
> after significant changes, using the mechanism provided by GitHub (i.e. the 
> button with the two

To be more precise: not all reviews need to be invalidated by requesting a 
re-review, only the approvals.

Re-requesting reviews on GitHub

2019-10-30 Thread Dr. Matthias St. Pierre 
Independently of the new 'approval: *' state labelling I was wondering whether 
it wouldn't
be a good idea to adopt the habit of explicitly requesting a re-review from the 
other reviewers
after significant changes, using the mechanism provided by GitHub (i.e. the 
button with the two
circling arrows next to the reviewer entry). In that way, outdated reviews 
would become more
visible, and outdated reviews wouldn't be addrev'ed to the commit message when 
merging,
unless they are renewed before the 24h grace period expires.  For nit changes, 
the current informal
way of re-approval could be kept of course.

What's your opinion?

Matthias