Re: Should the return result of CRYPTO_UP_REF() / CRYPTO_DOWN_REF() be checked?

2020-02-10 Thread Bernd Edlinger
On 2/10/20 6:29 PM, Kurt Roeckx wrote: > On Mon, Feb 10, 2020 at 04:19:20PM +, Matt Caswell wrote: >> >> >> On 10/02/2020 00:15, SHANE LONTIS wrote: >>> With the new architecture changes there are quite a few new calls to >>> >>> CRYPTO_UP_REF() >>> CRYPTO_DOWN_REF() >>> >>> These methods

Re: Should the return result of CRYPTO_UP_REF() / CRYPTO_DOWN_REF() be checked?

2020-02-10 Thread Kurt Roeckx
On Mon, Feb 10, 2020 at 04:19:20PM +, Matt Caswell wrote: > > > On 10/02/2020 00:15, SHANE LONTIS wrote: > > With the new architecture changes there are quite a few new calls to > > > > CRYPTO_UP_REF() > > CRYPTO_DOWN_REF() > > > > These methods return an int that is not being checked in

Re: Should the return result of CRYPTO_UP_REF() / CRYPTO_DOWN_REF() be checked?

2020-02-10 Thread Matt Caswell
On 10/02/2020 00:15, SHANE LONTIS wrote: > With the new architecture changes there are quite a few new calls to > > CRYPTO_UP_REF() > CRYPTO_DOWN_REF() > > These methods return an int that is not being checked in lots of places. > > This return value only seems to affect fallback code that

Should the return result of CRYPTO_UP_REF() / CRYPTO_DOWN_REF() be checked?

2020-02-09 Thread SHANE LONTIS
With the new architecture changes there are quite a few new calls to CRYPTO_UP_REF() CRYPTO_DOWN_REF() These methods return an int that is not being checked in lots of places. This return value only seems to affect fallback code that calls CRYPTO_atomic_add (which can return 0 on lock or