Re: proposed change to committers policy

2019-05-24 Thread Salz, Rich
Nicely worded. It doesn’t go as far as I’d like, but it’s a step.

AW: proposed change to committers policy

2019-05-24 Thread Dr. Matthias St. Pierre
> > IMHO an important clarification needs to be made: The rule should not be > > about > > _prohibiting_ double approvals. It should only be about _counting_ them. > > I would not deprive people of the right to state their opinions. > > Isn't that an implementation detail? You're right, it

Re: proposed change to committers policy

2019-05-24 Thread Richard Levitte
On Fri, 24 May 2019 11:21:18 +0200, Matthias St. Pierre wrote: > > >   In considering approvals, the combined approvals must come > >   from individuals who work for separate organisations. > >   This condition does not apply where the organisation is the > >   OSF or OSS. > > >

Re: proposed change to committers policy

2019-05-24 Thread Tim Hudson
On Fri, May 24, 2019 at 7:34 PM Matt Caswell wrote: > On 24/05/2019 10:28, SHANE LONTIS wrote: > > It doesn’t stop us both reviewing a PR. That doesn’t mean we both need > to approve. > > Right...but in Matthias's version if you raise a PR, and then Pauli > approves it, > then you only then need

Re: proposed change to committers policy

2019-05-24 Thread Matt Caswell
On 24/05/2019 10:28, SHANE LONTIS wrote: > It doesn’t stop us both reviewing a PR. That doesn’t mean we both need to > approve. Right...but in Matthias's version if you raise a PR, and then Pauli approves it, then you only then need to get a second committer approval. Otherwise you would need to

Re: proposed change to committers policy

2019-05-24 Thread SHANE LONTIS
It doesn’t stop us both reviewing a PR. That doesn’t mean we both need to approve. > On 24 May 2019, at 7:21 pm, Matthias St. Pierre > wrote: > > > > > In considering approvals, the combined approvals must come > > from individuals who work for separate organisations. > >