Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-02-13 Thread Matt Caswell
On 12/02/2019 10:08, Matt Caswell wrote: > > > On 07/02/2019 15:03, Matt Caswell wrote: >> That would make the proposed vote text for this OMC vote: >> >> "master and 1.1.1 will be updated so that they do not signal the start and >> end >> of post-handshake message exchanges in the info

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-02-12 Thread Matt Caswell
On 07/02/2019 15:03, Matt Caswell wrote: > That would make the proposed vote text for this OMC vote: > > "master and 1.1.1 will be updated so that they do not signal the start and end > of post-handshake message exchanges in the info callback using > SSL_CB_HANDSHAKE_START and

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-02-07 Thread Matt Caswell
On 06/02/2019 23:11, Kurt Roeckx wrote: > On Thu, Jan 31, 2019 at 02:19:28PM -0600, David Benjamin wrote: >> On Thu, Jan 31, 2019 at 2:01 PM Matt Caswell wrote: >> >>> >>> On 31/01/2019 18:50, David Benjamin wrote: We will see if this damage turns out fatal for KeyUpdate, but OpenSSL >>>

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-02-06 Thread Kurt Roeckx
On Thu, Jan 31, 2019 at 02:19:28PM -0600, David Benjamin wrote: > On Thu, Jan 31, 2019 at 2:01 PM Matt Caswell wrote: > > > > > On 31/01/2019 18:50, David Benjamin wrote: > > > We will see if this damage turns out fatal for KeyUpdate, but OpenSSL > > can at > > > least help slow its spread by

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-31 Thread Matt Caswell
On 31/01/2019 18:50, David Benjamin wrote: > We will see if this damage turns out fatal for KeyUpdate, but OpenSSL can at > least help slow its spread by issuing a fix That's precisely what PR 8096 does. > As a heuristic for API design: if the caller needs to know the implementation > details

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-31 Thread David Benjamin
On Wed, Jan 30, 2019 at 11:20 AM Kurt Roeckx wrote: > On Wed, Jan 30, 2019 at 10:44:12AM +, Matt Caswell wrote: > > > > > > On 29/01/2019 19:27, David Benjamin wrote: > > > On Tue, Jan 29, 2019 at 11:31 AM Kurt Roeckx > > > wrote: > > > > > > On Tue, Jan 29, 2019

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-30 Thread Matt Caswell
On 30/01/2019 17:20, Kurt Roeckx wrote: > On Wed, Jan 30, 2019 at 10:44:12AM +, Matt Caswell wrote: >> >> >> On 29/01/2019 19:27, David Benjamin wrote: >>> On Tue, Jan 29, 2019 at 11:31 AM Kurt Roeckx >> > wrote: >>> >>> On Tue, Jan 29, 2019 at 02:07:09PM +,

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-30 Thread Kurt Roeckx
On Wed, Jan 30, 2019 at 10:44:12AM +, Matt Caswell wrote: > > > On 29/01/2019 19:27, David Benjamin wrote: > > On Tue, Jan 29, 2019 at 11:31 AM Kurt Roeckx > > wrote: > > > > On Tue, Jan 29, 2019 at 02:07:09PM +, Matt Caswell wrote: > > > So I plan to

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-30 Thread Benjamin Kaduk
On Wed, Jan 30, 2019 at 09:02:30AM +0100, Kurt Roeckx wrote: > On Tue, Jan 29, 2019 at 02:07:09PM +, Matt Caswell wrote: > > So I plan to start the vote soon for merging PR#8096 and backporting it to > > 1.1.1. This is a breaking change as previously discussed. > > > > My proposed vote text

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-30 Thread Matt Caswell
On 29/01/2019 19:27, David Benjamin wrote: > On Tue, Jan 29, 2019 at 11:31 AM Kurt Roeckx > wrote: > > On Tue, Jan 29, 2019 at 02:07:09PM +, Matt Caswell wrote: > > So I plan to start the vote soon for merging PR#8096 and backporting it > to > > 1.1.1.

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-30 Thread Matt Caswell
On 29/01/2019 17:31, Kurt Roeckx wrote: > On Tue, Jan 29, 2019 at 02:07:09PM +, Matt Caswell wrote: >> So I plan to start the vote soon for merging PR#8096 and backporting it to >> 1.1.1. This is a breaking change as previously discussed. >> >> My proposed vote text is as follows. Please

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-30 Thread Kurt Roeckx
On Tue, Jan 29, 2019 at 02:07:09PM +, Matt Caswell wrote: > So I plan to start the vote soon for merging PR#8096 and backporting it to > 1.1.1. This is a breaking change as previously discussed. > > My proposed vote text is as follows. Please let me know asap of any feedback. > Otherwise I

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-29 Thread Benjamin Kaduk
On Tue, Jan 29, 2019 at 01:27:24PM -0600, David Benjamin wrote: > On Tue, Jan 29, 2019 at 11:31 AM Kurt Roeckx wrote: > > > On Tue, Jan 29, 2019 at 02:07:09PM +, Matt Caswell wrote: > > > So I plan to start the vote soon for merging PR#8096 and backporting it > > to > > > 1.1.1. This is a

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-29 Thread Kurt Roeckx
On Tue, Jan 29, 2019 at 01:27:24PM -0600, David Benjamin wrote: > I think one clear conclusion from this incident is that this sort of > low-level API should be avoided, or people will use them in finicky ways > that break unexpectedly when you change things. Better defer such > mechanisms to when

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-29 Thread David Benjamin
On Tue, Jan 29, 2019 at 11:31 AM Kurt Roeckx wrote: > On Tue, Jan 29, 2019 at 02:07:09PM +, Matt Caswell wrote: > > So I plan to start the vote soon for merging PR#8096 and backporting it > to > > 1.1.1. This is a breaking change as previously discussed. > > > > My proposed vote text is as

Re: [openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-29 Thread Kurt Roeckx
On Tue, Jan 29, 2019 at 02:07:09PM +, Matt Caswell wrote: > So I plan to start the vote soon for merging PR#8096 and backporting it to > 1.1.1. This is a breaking change as previously discussed. > > My proposed vote text is as follows. Please let me know asap of any feedback. > Otherwise I

[openssl-project] Proposed vote text for the SSL_CB_HANDSHAKE_START change

2019-01-29 Thread Matt Caswell
So I plan to start the vote soon for merging PR#8096 and backporting it to 1.1.1. This is a breaking change as previously discussed. My proposed vote text is as follows. Please let me know asap of any feedback. Otherwise I will start the vote soon. "master and 1.1.1 will be updated to use