I think we should make sure to set aside time to review as many of the
non-project pull requests as possible. I think it is important to show a
commitment to the larger community.
One way to do this is to say that we will extend the BETA date by a week, and
in that week no new code from the
On Wed, Mar 07, 2018 at 01:20:41AM +, Salz, Rich wrote:
> I think we should make sure to set aside time to review as many of the
> non-project pull requests as possible. I think it is important to show a
> commitment to the larger community.
I agree. I started looking at this last week,
If you are blocked on review please drop a note (like the one you just did)
to the group.
Some of us review the specifically blocked things when such notes are sent.
#3082 is already closed and merged - did you mean another PR?
#3958 approved (in case Richard doesn't get back to it)
#1130
On Wed, Mar 07, 2018 at 03:01:03PM +1000, Tim Hudson wrote:
> If you are blocked on review please drop a note (like the one you just did)
> to the group.
> Some of us review the specifically blocked things when such notes are sent.
>
> #3082 is already closed and merged - did you mean another PR?
Hi,
Andy pointed out that my last e-mail was probably not clear enough.
I want to drop the current partially overlapping checks
on the WRAP mode ciphers (which were ineffective anyways).
And allow the following additional use case for any cipher
unsigned char *in = buf + sizeof(buf) - X, *out