Re: OTC VOTE: Accept PR#16286 into 3.0 subject to the normal review process

2021-08-29 Thread Kurt Roeckx
On Tue, Aug 17, 2021 at 02:19:08PM +0100, Matt Caswell wrote: > topic: Accept PR#16286 into 3.0 subject to the normal review process -1 Do we need some general policy for such changes after the 3.0 release? Kurt

Re: OTC quick votes [WAS: RE: OTC vote PR #16171: config_diagnostic]

2021-08-29 Thread Kurt Roeckx
I currently fail to see why you can't describe in words what you intend to fix. The PR itself has a subject, so have the commits. One of the reasons we have this vote is public is so that people reading this list can comment on it. Just some number doesn't tell them anything without having to go

Re: OTC VOTE: Accept PR#16286 into 3.0 subject to the normal review process

2021-08-29 Thread Dmitry Belyavsky
On Sun, Aug 29, 2021 at 1:36 PM Kurt Roeckx wrote: > On Tue, Aug 17, 2021 at 02:19:08PM +0100, Matt Caswell wrote: > > topic: Accept PR#16286 into 3.0 subject to the normal review process > > -1 > > Do we need some general policy for such changes after the 3.0 > release? > > I think we need some

Re: OTC quick votes [WAS: RE: OTC vote PR #16171: config_diagnostic]

2021-08-29 Thread Tim Hudson
You cannot meaningfully vote on the PR without reviewing it. It is that simple. There is zero point in providing details beyond that as the PR is the details. The subject of the PR doesn't remove the need to read the details to form a view. The commentary on the PR and the code itself is what