Re: Welcoming our new committers

2019-05-21 Thread Dmitry Belyavsky
lcome our four new committers as announced here: > > https://www.openssl.org/blog/blog/2019/05/20/committers/ > > The new committers are: > > Dmitry Belyavsky, Shane Lontis, Tomáš Mráz and Patrick Steuer. > > Welcome all! > > Matt > -- SY, Dmitry Belyavsky

Re: punycode licensing

2019-07-10 Thread Dmitry Belyavsky
base. >> >> >> >> So why does the project require permission from other Apache-licensed >> licensed software? In other words, why will the project not accept and use >> the rights, covered by copyright and license, that it grants to others? >> >> >> > -- SY, Dmitry Belyavsky

Re: punycode licensing

2019-08-05 Thread Dmitry Belyavsky
Dear Tim, Sorry for the delay with the response. On Thu, Jul 11, 2019 at 2:44 AM Tim Hudson wrote: > On Thu, Jul 11, 2019 at 12:37 AM Dmitry Belyavsky > wrote: > >> Dear Tim, >> >> Formally I am a contributor with a signed CLA. >> I took a code definitely

Re: Cleaning up include file inconsistencies

2019-07-06 Thread Dmitry Belyavsky
sted by a source tree vote: > >~/src/openssl$ find -name '*_lcl.h' | wc -l >19 > ~/src/openssl$ find -name '*_locl.h' | wc -l > 30 > > What's your opinion about renaming of those files? > > Matthias > > -- SY, Dmitry Belyavsky

Re: Malloc failures check

2019-11-21 Thread Dmitry Belyavsky
off-list discusson: > > > > i=0 > > while : ; do > >((i++)) > >export MALLOC_FAILURE_CHECKS=${i}@100 openssl foo etc… > >test -f core && echo crashed && exit 1 > > done > > > > > -- SY, Dmitry Belyavsky

Re: Flaw in our process for dealing with trivial changes

2019-12-12 Thread Dmitry Belyavsky
Dear Matt, On Thu, Dec 12, 2019 at 1:25 PM Matt Caswell wrote: > > On 12/12/2019 09:29, Dmitry Belyavsky wrote: > > - the contributor agreed to sign the CLA and > > - there was a mark that CLA is signed and > > - all the necessary approves were present > > I de

Re: Flaw in our process for dealing with trivial changes

2019-12-12 Thread Dmitry Belyavsky
and no CLA on file, it seems > possible to me that we could push commit all the way through the process > without the reviewers even realising that the author is claiming > triviality on the commit. > > Not sure what the solution to that is. > > Matt > -- SY, Dmitry Belyavsky

Re: Flaw in our process for dealing with trivial changes

2019-12-12 Thread Dmitry Belyavsky
Great idea. пт, 13 дек. 2019 г., 0:31 Dr Paul Dale : > A red blocker along the lines of: “Triviality Unconfirmed”. One of the > reviewers needs to remove this before the PR can be merged. > > It’s in our face, it prevent accidental merges and its low overhead. > > > Pauli > -- > Dr Paul Dale |

Malloc failures check

2019-11-20 Thread Dmitry Belyavsky
Hello, Observing a series of similar bugs related to a lack of checks of the malloc return values, I wonder if we could automate the search of these errors on the compile level (e.g. similar to the __owur macro)? -- SY, Dmitry Belyavsky

Re: New GitHub Project Landing Page

2020-02-26 Thread Dmitry Belyavsky
Looks great! Many thanks for your efforts! On Wed, Feb 26, 2020 at 11:13 PM Dr. Matthias St. Pierre < matthias.st.pie...@ncp-e.com> wrote: > The OpenSSL Project GitHub has a new landing page: > > https://github.com/openssl/openssl > > Scroll down. Enjoy. > > >

Re: New Committer

2020-01-31 Thread Dmitry Belyavsky
; Welcome David! > > Matt > -- SY, Dmitry Belyavsky

Re: Github PR label automation

2020-02-08 Thread Dmitry Belyavsky
f the approval: done label gets set again then after 24 hours > the existing automation will trigger. #10786 is a good example of > this. > > Mark > -- SY, Dmitry Belyavsky

Re: Deprecation

2020-02-14 Thread Dmitry Belyavsky
Dear Matt, On Fri, Feb 14, 2020 at 12:48 PM Matt Caswell wrote: > > > On 14/02/2020 09:41, Dmitry Belyavsky wrote: > > Hello, > > > > On Fri, Feb 14, 2020 at 5:30 AM Dr Paul Dale > <mailto:paul.d...@oracle.com>> wrote: > > > > Th

Re: Deprecation

2020-02-14 Thread Dmitry Belyavsky
Dear Richard, On Fri, Feb 14, 2020 at 1:37 PM Richard Levitte wrote: > On Fri, 14 Feb 2020 10:41:05 +0100, > Dmitry Belyavsky wrote: > > > > > > Hello, > > > > On Fri, Feb 14, 2020 at 5:30 AM Dr Paul Dale > wrote: > > > > There is some pu

Re: Deprecation

2020-02-14 Thread Dmitry Belyavsky
_0_0 # 29 Mar 2010 > OPENSSL_NO_DEPRECATED_1_0_1 # 14 Mar 2012 > -- SY, Dmitry Belyavsky

Re: Deprecation

2020-02-14 Thread Dmitry Belyavsky
both as open-source and commercial engine developer seems reasonable to delay conversion from engines to providers at least until 3.0.0 feature freeze happens. But some features I'm interested in imply engine model (and it will be great if somebody else could look at PR 10904 to avoid it when possible). -- SY, Dmitry Belyavsky

Re: crypt(3)

2020-01-16 Thread Dmitry Belyavsky
ughts? Other alternatives? > > > Pauli > -- > Dr Paul Dale | Distinguished Architect | Cryptographic Foundations > Phone +61 7 3031 7217 > Oracle Australia > > -- SY, Dmitry Belyavsky

Re: 3.0 release timeline proposal

2020-01-07 Thread Dmitry Belyavsky
When does the feature freeze happen? I'm interested in publishing as much GOST support as possible. On Tue, 7 Jan 2020, 14:13 Matt Caswell, wrote: > Hi all > > Myself, Paul, Shane, Richard and Nicola had a conf call today to discuss > the outstanding tasks and effort required to get us to a

Re: 3.0 release timeline proposal

2020-01-07 Thread Dmitry Belyavsky
Many thanks! Got it, and I think this should be directly written. On Tue, 7 Jan 2020, 16:05 Matt Caswell, wrote: > > > On 07/01/2020 13:00, Dmitry Belyavsky wrote: > > When does the feature freeze happen? > > I'm interested in publishing as much GOST support as possible

Re: 3.0 release timeline proposal

2020-01-07 Thread Dmitry Belyavsky
Sorry. My fault :( On Tue, 7 Jan 2020, 16:35 Matt Caswell, wrote: > > > On 07/01/2020 13:26, Dmitry Belyavsky wrote: > > Many thanks! > > > > Got it, and I think this should be directly written. > > It was!! > > beta1, 2020-06-02: Code complete

Re: Deprecating misleading GOST names

2020-03-30 Thread Dmitry Belyavsky
Dear Hubert, Done: https://github.com/openssl/openssl/pull/11440 On Fri, Mar 20, 2020 at 6:27 PM Hubert Kario wrote: > On Friday, 20 March 2020 13:17:48 CET, Dmitry Belyavsky wrote: > > Hello, > > > > I came across wrong naming for some GOST-related stuff in object.txt.

Re: 1.1.1f

2020-03-26 Thread Dmitry Belyavsky
ken quite a bit of stuff, I propose > that we do a 1.1.1f soon (possibly next Tuesday - 31st March). > > Thoughts? > I strongly support this idea. -- SY, Dmitry Belyavsky

Re: Stale PR stats @May01

2020-05-01 Thread Dmitry Belyavsky
22 > 7225 reviewed:commented days:587 > 6725 milestone:Assessed, reviewed:approved days:330 > 6518 milestone:Assessed, reviewed:approved days:681 > 6516 branch: 1.1.1, branch: master, milestone:Assessed, days:681 > 6448 milestone:Assessed, days:188 > 6219 milestone:Assessed, reviewed:approved days:719 > 5427 branch: master, milestone:Assessed, reviewed:commented days:481 > 4487 milestone:Assessed, days:658 > -- SY, Dmitry Belyavsky

Re: Stale PR stats @May01

2020-05-01 Thread Dmitry Belyavsky
On Fri, May 1, 2020 at 6:19 PM Mark J Cox wrote: > On Fri, May 1, 2020 at 3:30 PM Dmitry Belyavsky wrote: > .. > > And I also got an idea that ping comment leaves PRs out of this > statistics :) > > Thanks! The script is designed to ignore the automated pings that i

Re: Unexpected EOF handling

2020-05-08 Thread Dmitry Belyavsky
; > If the default behaviour should be to make it a non-fatal error, > like the old behaviour is, I would really prefer a different > error, one that's not SSL_ERROR_SYSCALL or SSL_ERROR_SSL. > > So I think the suggestion is to have this: > - By default, SSL_ERROR_SSL is returned with > SSL_R_UNEXPECTED_EOF_WHILE_READING, the session will be > marked invalid. > - With an option, SSL_ERROR_ZERO_RETURN is returned, the session > will stay valid. > If I remember correctly, session resumption is a way to significantly reduce a server's workload. So I think that by default (and maybe the only option) we should prefer the old behaviour. -- SY, Dmitry Belyavsky

Re: Unexpected EOF handling

2020-05-11 Thread Dmitry Belyavsky
or, > > like the old behaviour is, I would really prefer a different > > error, one that's not SSL_ERROR_SYSCALL or SSL_ERROR_SSL. > > > > So I think the suggestion is to have this: > > - By default, SSL_ERROR_SSL is returned with > > SSL_R_UNEXPECTED_EOF_WHILE_RE

Re: Some more extra tests

2020-05-11 Thread Dmitry Belyavsky
Dear Nicola, Please see https://github.com/openssl/openssl/pull/11792 It currently does not enable TCL and Perl tests, but the C tests also helped me to find regression in the master branch. On Thu, May 7, 2020 at 10:55 PM Dmitry Belyavsky wrote: > Dear Nicola, > > I feel a signifi

Re: Alpha2

2020-05-08 Thread Dmitry Belyavsky
Dear Matt, The workaround for the 11763 is implemented, 11764 seems to be fixed now, so no objections from my side. Happy weekend! On Fri, May 8, 2020 at 11:58 AM Dmitry Belyavsky wrote: > Dear Matt, > > I kindly ask not to make release until issues raised in #11763 and #11764 &g

Deprecating misleading GOST names

2020-03-20 Thread Dmitry Belyavsky
y inconvenient. I'd like to fix these issues in the upcoming 3.0 release, so any ideas about how to deal with it are welcome. Some of this stuff can be fixed on the engine level, but it's better to avoid misleading naming. -- SY, Dmitry Belyavsky

Re: Some more extra tests

2020-05-07 Thread Dmitry Belyavsky
need to test more thoroughly to ensure we are not > breaking the engine API! > > > Nicola > > On Thu, May 7, 2020, 21:08 Dmitry Belyavsky wrote: > >> Dear colleagues, >> >> Let me draw your attention to a potentially reasonable set of extended >> tes

Re: Unexpected EOF handling

2020-05-07 Thread Dmitry Belyavsky
returned apart from the unclean EOF condition? > > I can't really think of any. > > So I would be just for properly documenting the condition and keeping > it as is if the SSL_OP to ignore unclean EOF is in effect. > > -- > Tomáš Mráz > No matter how far down the wrong road you've gone, turn back. > Turkish proverb > [You'll know whether the road is wrong if you carefully listen to your > conscience.] > > > -- SY, Dmitry Belyavsky

Some more extra tests

2020-05-07 Thread Dmitry Belyavsky
of known problems). I will be happy to assist in enabling these tests as a part of openssl test suites. Many thanks! -- SY, Dmitry Belyavsky

Re: Alpha2

2020-05-08 Thread Dmitry Belyavsky
elease > next week (on Thursday 14th May). Unless I hear objections otherwise, I > plan to go with that. > > Matt > -- SY, Dmitry Belyavsky

Detecting Bad OpenSSL Usage

2020-05-31 Thread Dmitry Belyavsky
Hello, Here is a nice article about a tool desired to catch misuse of the OpenSSL API. https://blog.trailofbits.com/2020/05/29/detecting-bad-openssl-usage/ I'm not sure whether it's worth using by the team but maybe it's worth mentioning in OpenSSL Wiki. -- SY, Dmitry Belyavsky

My vacation

2020-07-23 Thread Dmitry Belyavsky
Hello, I go on my vacation from July 24 to August 5. On vacation, my internet access is very limited. If you have smth urgent, please let me know via direct email. Many thanks! -- SY, Dmitry Belyavsky