Re: Re-requesting reviews on GitHub
On 30.10.19 10:14, Richard Levitte wrote: This is a good idea, and also a detectable event for a bot to listen to. Sounds like an excellent idea: If approvals and dismissals of approvals (resp. re-review requests) are all bot events, then the bot should be able to handle most state changes automatically, including the determination whether a normal or an omc review is required. This would be a great ease for the reviewer's workflow. Matthias
Re: Re-requesting reviews on GitHub
I think its a good idea. It would prevent issues like https://github.com/openssl/openssl/pull/9501 Patrick
Re: Re-requesting reviews on GitHub
This is a good idea, and also a detectable event for a bot to listen to. Cheers Richard "Dr. Matthias St. Pierre" skrev: (30 oktober 2019 09:30:11 CET) >> Independently of the new 'approval: *' state labelling I was >wondering whether it wouldn't >> be a good idea to adopt the habit of explicitly requesting a >re-review from the other reviewers >> after significant changes, using the mechanism provided by GitHub >(i.e. the button with the two > >To be more precise: not all reviews need to be invalidated by >requesting a re-review, only the approvals. -- Skickat från min Android-enhet med K-9 Mail. Ursäkta min fåordighet.
