Re: Handling signature_algorithm extension on TLS1.3 server

2019-06-07 Thread Viktor Dukhovni
> On Jun 7, 2019, at 12:07 PM, Hubert Kario wrote: > > OTOH, the practice in TLS 1.2, and behaviour codified in TLS 1.3 RFC, is that > if you have just one chain, give it to client and let it sort out if it likes > it or not Absolutely. The text in RFC5246 is a specification overreach from

Re: Handling signature_algorithm extension on TLS1.3 server

2019-06-07 Thread Hubert Kario
On Friday, 7 June 2019 14:42:26 CEST Raja Ashok wrote: > > This was an area of some ambiguity in the TLSv1.2 spec where only > > signature_algorithms exists. I believe it was common practice for > > implementations to not check the signatures in certificates for > > conformance with > > this (certa

Re: Handling signature_algorithm extension on TLS1.3 server

2019-06-07 Thread Raja Ashok
> > This was an area of some ambiguity in the TLSv1.2 spec where only > signature_algorithms exists. I believe it was common practice for > implementations to not check the signatures in certificates for > conformance with > this (certainly that is the way OpenSSL behaves). The TLSv1.3 spec seems >

Re: Handling signature_algorithm extension on TLS1.3 server

2019-06-07 Thread Matt Caswell
On 07/06/2019 07:27, Raja Ashok wrote: > Thanks for the detailed explanation. > > So rsaEncryption cert can do both RSASSA-PKCS-v1_5 and RSASSA-PSS type > signature. And also the digital signature present on the cert can be of type > RSASSA-PKCS-v1_5 or RSASSA-PSS. > > Currently in 1.1.1c's ha

Re: Handling signature_algorithm extension on TLS1.3 server

2019-06-06 Thread Raja Ashok
Thanks for the detailed explanation. So rsaEncryption cert can do both RSASSA-PKCS-v1_5 and RSASSA-PSS type signature. And also the digital signature present on the cert can be of type RSASSA-PKCS-v1_5 or RSASSA-PSS. Currently in 1.1.1c's has_usable_cert() function, digital signature (Issuer's si

Re: Handling signature_algorithm extension on TLS1.3 server

2019-06-06 Thread Matt Caswell
On 06/06/2019 16:15, Raja Ashok wrote: > Hi, > > Currently has_usable_cert() function is called on tls_choose_sigalg() to find > out the suitable certificate available. But currently rsa_pkcs1_xxx and > rsa_pss_rsae_xxx certs are stored on same index SSL_PKEY_RSA. Because of this > it > may en

Handling signature_algorithm extension on TLS1.3 server

2019-06-06 Thread Raja Ashok
Hi, Currently has_usable_cert() function is called on tls_choose_sigalg() to find out the suitable certificate available. But currently rsa_pkcs1_xxx and rsa_pss_rsae_xxx certs are stored on same index SSL_PKEY_RSA. Because of this it may ends in choosing rsa_pkcs1_xxx cert for rsa_pss_rsae_xxx ex