Re: Should SSL_get_servername() depend on SNI callback (no-)ACK?

2019-10-22 Thread Stephen Farrell
Hiya, On 22/10/2019 17:09, Yann Ylavic wrote: > Sorry for the shortcut, by "tlsext_hostname" I meant the name of the > field in SSL_SESSION_ASN1. > My observation is that when browsers resume a session, s->hit is set > but s->session->ext.hostname is NULL, which I interpret as no SNI > found in t

Re: Should SSL_get_servername() depend on SNI callback (no-)ACK?

2019-10-22 Thread Yann Ylavic
On Tue, Oct 22, 2019 at 5:09 PM Benjamin Kaduk wrote: > > There's some (additional?) discussion on this topic in > https://github.com/openssl/openssl/pull/10018 . A couple comments inline, > though... Thanks, will look at it. More comment below too... > On Tue, Oct 22, 2019 at 02:30:37PM +020

Re: Should SSL_get_servername() depend on SNI callback (no-)ACK?

2019-10-22 Thread Benjamin Kaduk via openssl-users
There's some (additional?) discussion on this topic in https://github.com/openssl/openssl/pull/10018 . A couple comments inline, though... On Tue, Oct 22, 2019 at 02:30:37PM +0200, Yann Ylavic wrote: > Hi, > > in master (and 1.1.1), SSL_get_servername() returns either > s->session->ext.hostname

Should SSL_get_servername() depend on SNI callback (no-)ACK?

2019-10-22 Thread Yann Ylavic
Hi, in master (and 1.1.1), SSL_get_servername() returns either s->session->ext.hostname (when s->hit == 1), or s->ext.hostname (otherwise). It seems, according to final_server_name(), that s->session->ext.hostname is set only: if (sent && ret == SSL_TLSEXT_ERR_OK && (!s->hit || SSL_IS_TLS