> From: Michael Richardson
> Sent: Friday, 1 April, 2022 07:40
>
> Michael Wojcik wrote:
> > Actually, in the context of #if expressions, unrecognized tokens
> expand to 0 anyway:
>
> > After all replacements due to macro expansion and the defined unary
> > operator have been
Michael Wojcik wrote:
> Actually, in the context of #if expressions, unrecognized tokens expand
to 0 anyway:
> After all replacements due to macro expansion and the defined unary
> operator have been performed, all remaining identifiers are replaced
> with the pp-number 0...
> From: Michael Richardson
> Sent: Thursday, 31 March, 2022 14:18
>
> Michael Wojcik wrote:
> > #if defined OPENSSL_SYS_WINDOWS
> > # include
> > #else
> > # include
> > #endif
>
> But, don't all the OPENSSL_* macros expand to 0/1, anyway, so we actually
> just want #if
> From: openssl-users On Behalf Of
> Michael Richardson
> Sent: Thursday, 31 March, 2022 14:19
>
> The clang-9 test fails with:
>
> # ERROR: @ test/bio_dgram_test_helpers.c:150
> # failed to v6 bind socket: Permission denied
> #
> #
> #
The clang-9 test fails with:
# ERROR: @ test/bio_dgram_test_helpers.c:150
# failed to v6 bind socket: Permission denied
#
#
# OPENSSL_TEST_RAND_ORDER=1648577511
not ok 2 - iteration 1
Michael Wojcik wrote:
> #if defined OPENSSL_SYS_WINDOWS
> # include
> #else
> # include
> #endif
But, don't all the OPENSSL_* macros expand to 0/1, anyway, so we actually
just want #if OPENSSL_SYS_WINDOWS?
> (Note C does not require the argument of the operator
> From: openssl-users On Behalf Of Matt
> Caswell
> Sent: Tuesday, 22 March, 2022 10:31
>
> There is already code in bss_dgram.c that is conditionally compiled on
> OPENSSL_USE_IPV6. Is it reasonable to assume that if AF_INET6 is defined
> then ip6.h exists?
I meant to look into this earlier
Matt Caswell wrote:
> There is already code in bss_dgram.c that is conditionally compiled on
> OPENSSL_USE_IPV6. Is it reasonable to assume that if AF_INET6 is
> defined then ip6.h exists?
I think so, so I changed that code, and also made it consistently use
OPENSSL_USE_IPV6, rather
On 22/03/2022 16:22, Michael Richardson wrote:
Michael Wojcik wrote:
> The RFC specifically mentions using this API to retrieve and set
> addresses, so it seems like a fix for issue 5257 does need to use it,
> if that's to be done in a portable way.
> 3542 is only
Matt Caswell wrote:
>> Matt Caswell wrote: > Nit; We insert an
>> extra space when enclosed within a "#if", i.e.
>>
>> I assume that this applies recursively?
> Yes.
>> I think that in some cases the indent could be quite deep.
> It hasn't been a major issue so
Michael Wojcik wrote:
> The RFC specifically mentions using this API to retrieve and set
> addresses, so it seems like a fix for issue 5257 does need to use it,
> if that's to be done in a portable way.
> 3542 is only Informational, but I'd expect most or all platforms with
> From: openssl-users On Behalf Of Matt
> Caswell
> Sent: Monday, 21 March, 2022 05:33
>
> Given that OpenSSL already supports IPv6 but we've never needed to
> include [netinet/ip6.h], I am wondering what is in that header that needs to
> be used?
netinet/ip6.h is for the "Advanced API for
On 19/03/2022 13:28, Michael Richardson wrote:
I'm working on dealing with Matt's detailed review.
This issue seems bigger than the github issue.
https://github.com/openssl/openssl/pull/5257
about: #include
matt> This remains an issue. It's unclear to me whether all of these headers
I'm working on dealing with Matt's detailed review.
This issue seems bigger than the github issue.
https://github.com/openssl/openssl/pull/5257
about: #include
matt> This remains an issue. It's unclear to me whether all of these headers
will
matt> be available on all platforms. At least
14 matches
Mail list logo
