Re: [Openstack] database migration cleanup

2012-05-03 Thread John Garbutt
Subject: Re: [Openstack] database migration cleanup - Original Message - From: Vishvananda Ishaya vishvana...@gmail.com To: Dan Prince dpri...@redhat.com Cc: openstack@lists.launchpad.net Sent: Thursday, April 26, 2012 4:14:25 PM Subject: Re: [Openstack] database migration cleanup

Re: [Openstack] database migration cleanup

2012-05-03 Thread Dan Prince
- Original Message - From: John Garbutt john.garb...@citrix.com To: Dan Prince dpri...@redhat.com, Vishvananda Ishaya vishvana...@gmail.com Cc: openstack@lists.launchpad.net Sent: Thursday, May 3, 2012 10:56:44 AM Subject: RE: [Openstack] database migration cleanup I may have

Re: [Openstack] database migration cleanup

2012-05-03 Thread Trey Morris
john.garb...@citrix.com To: Dan Prince dpri...@redhat.com, Vishvananda Ishaya vishvana...@gmail.com Cc: openstack@lists.launchpad.net Sent: Thursday, May 3, 2012 10:56:44 AM Subject: RE: [Openstack] database migration cleanup I may have missed this in the discussions, but does

Re: [Openstack] database migration cleanup

2012-05-02 Thread Dan Prince
- Original Message - From: Vishvananda Ishaya vishvana...@gmail.com To: Dan Prince dpri...@redhat.com Cc: openstack@lists.launchpad.net Sent: Thursday, April 26, 2012 4:14:25 PM Subject: Re: [Openstack] database migration cleanup +1. Might be nice to have some kind of test

Re: [Openstack] database migration cleanup

2012-04-30 Thread Dan Prince
Dague sda...@linux.vnet.ibm.com To: openstack@lists.launchpad.net Sent: Friday, April 27, 2012 10:21:17 AM Subject: Re: [Openstack] database migration cleanup On 04/26/2012 03:24 PM, Dan Prince wrote: snip I think this scheme would support users who follow stable releases as well

Re: [Openstack] database migration cleanup

2012-04-30 Thread Dan Prince
- Original Message - From: Johannes Erdfelt johan...@erdfelt.com To: openstack@lists.launchpad.net Sent: Friday, April 27, 2012 12:13:47 PM Subject: Re: [Openstack] database migration cleanup On Fri, Apr 27, 2012, Dan Prince dpri...@redhat.com wrote: Mirations don't appear

Re: [Openstack] database migration cleanup

2012-04-30 Thread Johannes Erdfelt
On Mon, Apr 30, 2012, Dan Prince dpri...@redhat.com wrote: The primary benefit here is it is simply less code to maintain: The old migrations scripts for Essex are around 6200 lines of code. The new compacted migration for Essex is around 950 lines of code. It seems like you're counting

Re: [Openstack] database migration cleanup

2012-04-27 Thread Thierry Carrez
Vishvananda Ishaya wrote: +1. Might be nice to have some kind of test to verify that the new migration leaves the tables in exactly the same state as the old migrations. Sounds like a good way to avoid nasty regressions. And maybe run that test (at least once) over the range of supported

Re: [Openstack] database migration cleanup

2012-04-27 Thread Eoghan Glynn
https://review.openstack.org/#/c/6847/ Nice! * Migrations added during Folsom release cycle could be compacted during E release cycle. TBD if/when we do the next compaction. An alternative idea would be to do the compaction *prior* to the Folsom relase instead of after, so that the

Re: [Openstack] database migration cleanup

2012-04-27 Thread Dan Prince
- Original Message - From: Eoghan Glynn egl...@redhat.com To: Dan Prince dpri...@redhat.com Cc: openstack@lists.launchpad.net Sent: Friday, April 27, 2012 5:45:27 AM Subject: Re: [Openstack] database migration cleanup https://review.openstack.org/#/c/6847/ Nice

Re: [Openstack] database migration cleanup

2012-04-27 Thread Sean Dague
On 04/26/2012 03:24 PM, Dan Prince wrote: snip I think this scheme would support users who follow stable releases as well as users who follow trunk very closely. We talked about this at the conference but I thought this issue might be near and dear to some of our end users so it was worth

Re: [Openstack] database migration cleanup

2012-04-27 Thread Dan Prince
- Original Message - From: Sean Dague sda...@linux.vnet.ibm.com To: openstack@lists.launchpad.net Sent: Friday, April 27, 2012 10:21:17 AM Subject: Re: [Openstack] database migration cleanup On 04/26/2012 03:24 PM, Dan Prince wrote: snip I think this scheme would support users

Re: [Openstack] database migration cleanup

2012-04-27 Thread Dan Prince
- Original Message - From: Johannes Erdfelt johan...@erdfelt.com To: openstack@lists.launchpad.net Sent: Friday, April 27, 2012 10:20:38 AM Subject: Re: [Openstack] database migration cleanup On Thu, Apr 26, 2012, Dan Prince dpri...@redhat.com wrote: The OpenStack Essex release

Re: [Openstack] database migration cleanup

2012-04-27 Thread Johannes Erdfelt
On Fri, Apr 27, 2012, Dan Prince dpri...@redhat.com wrote: Mirations don't appear to be particularly slow right now, and it doesn't appear that merging migrations will make them significantly faster. What exactly is the benefit of doing this? Speed wasn't the primary motivation here

Re: [Openstack] database migration cleanup

2012-04-27 Thread Monsyne Dragon
: [Openstack] database migration cleanup On 04/26/2012 03:24 PM, Dan Prince wrote: snip I think this scheme would support users who follow stable releases as well as users who follow trunk very closely. We talked about this at the conference but I thought this issue might be near and dear to some

Re: [Openstack] database migration cleanup

2012-04-27 Thread Johannes Erdfelt
On Fri, Apr 27, 2012, Monsyne Dragon mdra...@rackspace.com wrote: Even better, what would it take to try using Alembic? (http://alembic.readthedocs.org/en/latest/front.html#project-homepage) It's a big improvement over sqlalchemy. Amongst other things, migrations are not numbered, they are

[Openstack] database migration cleanup

2012-04-26 Thread Dan Prince
The OpenStack Essex release had 82 database migrations. As these grow in number it seems reasonable to clean house from time to time. Now seems as good a time as any. I came up with a first go at it here: https://review.openstack.org/#/c/6847/ The idea is that we would: * Do this early in

Re: [Openstack] database migration cleanup

2012-04-26 Thread Vishvananda Ishaya
+1. Might be nice to have some kind of test to verify that the new migration leaves the tables in exactly the same state as the old migrations. Vish On Apr 26, 2012, at 12:24 PM, Dan Prince wrote: The OpenStack Essex release had 82 database migrations. As these grow in number it seems