> there have been occasions where it's frustrated me that something I
> objected to got merged without my seeing it or while I was trying to
> comment.
I've heard of this several times in the past as well - some merge prop is
mid-review, and then it merges. Is there an easy mechanism to flag a r
ebula@lists.launchpad.net] On Behalf Of
> Johannes Erdfelt
> Sent: Tuesday, March 13, 2012 12:45 PM
> To: openstack@lists.launchpad.net
> Subject: Re: [Openstack] Gerrit minimum review time frame
>
> On Tue, Mar 13, 2012, Lorin Hochstein wrote:
> > As long as we're t
On Tue, Mar 13, 2012, Lorin Hochstein wrote:
> As long as we're talking about review issues, I'd really like to have a
> set of reviewing guidelines. Even better would be to have them in
> checklist form to make sure we don't miss things as we do reviews
> (checklists are great: http://gawande.com
On Mar 13, 2012, at 11:54 AM, Josh Kearney wrote:
> On Tue, Mar 13, 2012 at 5:07 AM, Soren Hansen wrote:
> 2012/3/13 Jesse Andrews :
> > Maybe it is just me, but most reviews seem to take hours to days to
> > complete. I'm been sitting here waiting for a one line change to get
> > a second "+2
ce at the summit if there continues to be
disagreement on the subject.
-Alex
-Original Message-
From: "Joe Gordon"
Sent: Monday, March 12, 2012 5:59pm
To: openstack@lists.launchpad.net
Subject: [Openstack] Gerrit minimum re
On Tue, Mar 13, 2012 at 3:58 PM, Josh Kearney wrote:
> On Tue, Mar 13, 2012 at 7:17 AM, Thierry Carrez
> wrote:
>>
>> So I'd rather work on formally splitting the nova-core group into
>> smaller topic-oriented review groups, which would ensure that code
>> affecting a given area is reviewed by th
Sent from my iPhone
On Mar 13, 2012, at 5:17 AM, Thierry Carrez wrote:
> Joe Gordon wrote:
>> I have noticed that some Gerrit branches get approved very quickly,
>> sometimes in a matter of minutes. While most of the time these
>> branches are vetted properly, the window for reviewing can be
On Tue, Mar 13, 2012 at 7:17 AM, Thierry Carrez wrote:
> So I'd rather work on formally splitting the nova-core group into
> smaller topic-oriented review groups, which would ensure that code
> affecting a given area is reviewed by the experts of that area (rather
> than by whoever happens to be o
On Tue, Mar 13, 2012 at 5:07 AM, Soren Hansen wrote:
> 2012/3/13 Jesse Andrews :
> > Maybe it is just me, but most reviews seem to take hours to days to
> > complete. I'm been sitting here waiting for a one line change to get
> > a second "+2 / approved" so I can redeploy our test cluster for th
On Tue, Mar 13, 2012, Mark McLoughlin wrote:
> On Mon, 2012-03-12 at 17:57 -0500, Josh Kearney wrote:
> > Is this is really a problem that needs solving? I'd like to believe that no
> > member of Nova Core would approve something that they aren't familiar with.
>
> I think the issue is more a cas
- Original Message -
> From: "Joe Gordon"
> To: openstack@lists.launchpad.net
> Sent: Monday, March 12, 2012 5:59:02 PM
> Subject: [Openstack] Gerrit minimum review time frame
>
> Hi All,
>
> I have noticed that some Gerrit branches get approved ver
Joe Gordon wrote:
> I have noticed that some Gerrit branches get approved very quickly,
> sometimes in a matter of minutes. While most of the time these
> branches are vetted properly, the window for reviewing can be so small
> that a non-trivial branch lands but without enough vetting. If someo
2012/3/13 John Garbutt :
> One extra concern. Since I work in the UK, most things happen while I
> am sleeping.
>
> Not sure I know of a good solution to that problem. A 12 hour window
> seems stupidly long,
No. No, it doesn't.
--
Soren Hansen | http://linux2go.dk/
Senior Software En
9:37
> To: openstack@lists.launchpad.net
> Subject: Re: [Openstack] Gerrit minimum review time frame
>
> Hi Joe,
>
> On 12/03/12 21:59, Joe Gordon wrote:
> > I have noticed that some Gerrit branches get approved very quickly,
> > sometimes in a matter of minutes. While most of th
2012/3/13 Jesse Andrews :
> Maybe it is just me, but most reviews seem to take hours to days to
> complete. I'm been sitting here waiting for a one line change to get
> a second "+2 / approved" so I can redeploy our test cluster for the
> last 2 hours.
Can we keep this discussion separate, please
Hi Joe,
On 12/03/12 21:59, Joe Gordon wrote:
> I have noticed that some Gerrit branches get approved very quickly,
> sometimes in a matter of minutes. While most of the time these
> branches are vetted properly, the window for reviewing can be so small
> that a non-trivial branch lands but witho
Obviously, a better review algorithm is required,
To avoid hungry condition of some branches.
Now the whole system feels more like a client/server model.
Maybe a peer to peer like model behaves better.
在 2012-3-13，15:13，"Jesse Andrews" 写道：
> Maybe it is just me, but most reviews seem to take
2012/3/12 Josh Kearney :
> Is this is really a problem that needs solving? I'd like to believe
> that no member of Nova Core would approve something that they aren't
> familiar with.
That's not the point. The review process isn't just about finding enough
people who agree with your change, it's ju
Maybe it is just me, but most reviews seem to take hours to days to
complete. I'm been sitting here waiting for a one line change to get
a second "+2 / approved" so I can redeploy our test cluster for the
last 2 hours.
When lots of people are active, reviews can be approved in quickly -
especiall
On Mon, 2012-03-12 at 17:57 -0500, Josh Kearney wrote:
> Is this is really a problem that needs solving? I'd like to believe that no
> member of Nova Core would approve something that they aren't familiar with.
I think the issue is more a case of allowing some time for other
reviewers to come alon
Is this is really a problem that needs solving? I'd like to believe that no
member of Nova Core would approve something that they aren't familiar with.
IMHO, we should be making better attempts at not letting branches sit
around for days/weeks at a time.
On Mon, Mar 12, 2012 at 4:59 PM, Joe Gordo
Hi All,
I have noticed that some Gerrit branches get approved very quickly,
sometimes in a matter of minutes. While most of the time these branches
are vetted properly, the window for reviewing can be so small that a
non-trivial branch lands but without enough vetting. If someone is in a
meetin
22 matches
Mail list logo
