Re: [Openstack] Don't bypass code-review.

2012-07-10 Thread Jason Kölker
On Tue, 2012-07-10 at 15:32 -0400, Eric Windisch wrote: > > > > Jenkins was failing to merge *ANY* code reviews for openstack-common. > > The root of the dependency tree of your patch sets is insufficient to > > make the test suite pass. The set of patches needed to go in in one > > commit. I was

Re: [Openstack] Don't bypass code-review.

2012-07-10 Thread Eric Windisch
> > Jenkins was failing to merge *ANY* code reviews for openstack-common. > The root of the dependency tree of your patch sets is insufficient to > make the test suite pass. The set of patches needed to go in in one > commit. I was ping'd on IRC to check into the tests that were failing > when the

Re: [Openstack] Don't bypass code-review.

2012-07-10 Thread Joshua Harlow
Slap on wrist bad person who did that, badness++ 'Those responsible have been sacked'??? -Josh On 7/10/12 10:52 AM, "Eric Windisch" wrote: I've had code reviews sitting out for over a week, looking to fix issues with the ZeroMQ driver in openstack-common. I'd love to get it fixed, and nudged

Re: [Openstack] Don't bypass code-review.

2012-07-10 Thread Jason Kölker
On Tue, 2012-07-10 at 13:52 -0400, Eric Windisch wrote: > I've had code reviews sitting out for over a week, looking to fix > issues with the ZeroMQ driver in openstack-common. I'd love to get it > fixed, and nudged a couple of people to get the reviews in, but > figured that it would get in eventu

Re: [Openstack] Don't bypass code-review.

2012-07-10 Thread Jay Pipes
On 07/10/2012 01:52 PM, Eric Windisch wrote: > I've had code reviews sitting out for over a week, looking to fix issues with > the ZeroMQ driver in openstack-common. I'd love to get it fixed, and nudged a > couple of people to get the reviews in, but figured that it would get in > eventually - a

[Openstack] Don't bypass code-review.

2012-07-10 Thread Eric Windisch
I've had code reviews sitting out for over a week, looking to fix issues with the ZeroMQ driver in openstack-common. I'd love to get it fixed, and nudged a couple of people to get the reviews in, but figured that it would get in eventually - and if not, I'd prod harder, or perhaps someone else t