Re: [Openstack] Questions About test_localization.py

2011-08-06 Thread Ed Leafe
On Aug 3, 2011, at 5:26 PM, Zed A. Shaw wrote: 1. Strings that have format but are *not* in a _() call. Not all strings, formatted or not, need to be localized - only those that are displayed to the user in some way. Formatting is frequently used as a more efficient concatenation

Re: [Openstack] Questions About test_localization.py

2011-08-03 Thread Zed A. Shaw
On Tue, Aug 02, 2011 at 04:48:54PM -0700, Vishvananda Ishaya wrote: On Aug 2, 2011, at 4:23 PM, Zed A. Shaw wrote: It does the same thing, but it's using the Python AST so it's accurate about what it's checking and source lines, etc. It is slower though, but about 2 seconds. :( No

Re: [Openstack] Questions About test_localization.py

2011-08-03 Thread Zed A. Shaw
On Wed, Aug 03, 2011 at 10:43:56PM +, Sandy Walsh wrote: 3. Maybe, write out a list of _() calls that aren't translated yet. Not sure if this is best in a test or as a tool though. What you think? Good idea. I like the way pep8 is run after the tests succeed. I can still hook it

[Openstack] Questions About test_localization.py

2011-08-02 Thread Zed A. Shaw
Hi All, I'm going to be spending my days for a little while just taking tests and source files that haven't been touched in a while and refactoring them or cleaning them up. The first one I picked was tests/test_localization.py, and I've refactored it to be this: http://codepad.org/YTODudUt It

Re: [Openstack] Questions About test_localization.py

2011-08-02 Thread Vishvananda Ishaya
On Aug 2, 2011, at 4:23 PM, Zed A. Shaw wrote: Hi All, I'm going to be spending my days for a little while just taking tests and source files that haven't been touched in a while and refactoring them or cleaning them up. Awesome. This should be very helpful. The first one I picked was

Re: [Openstack] Questions About test_localization.py

2011-08-02 Thread Dan Wendlandt
On Tue, Aug 2, 2011 at 4:48 PM, Vishvananda Ishaya vishvana...@gmail.comwrote: -1 The original purpose of the test was that people would add strings with multiple positional replacement strings. This is hard to translate in some cases, because the translators may need control over word