Re: [openstack-dev] [Cinder] Is there anyone truly working on this issue https://bugs.launchpad.net/cinder/+bug/1520102?

2015-12-10 Thread Thang Pham
I have to try it again myself. What errors are you seeing? Is it the same? Feel free to post a patch if you already have one that would solve it. Regards, Thang On Thu, Dec 10, 2015 at 10:51 PM, Sheng Bo Hou wrote: > Hi Mitsuhiro, Thang > > The patch

Re: [openstack-dev] [Cinder] Getting `ValueError: Field `volume_id' cannot be None`

2015-06-09 Thread Thang Pham
why a mock in one test module affects another. Given that mock.patch is working as evident from your patch, i will continue to use it. Thanks for helping out. On Thu, Jun 4, 2015 at 9:21 PM, Thang Pham thang.g.p...@gmail.com wrote: The problem is in your test case

Re: [openstack-dev] [Cinder] Getting `ValueError: Field `volume_id' cannot be None`

2015-06-04 Thread Thang Pham
The problem is in your test case. There is no such methods as remotefs.db.snapshot_get or remotefs.db.snapshot_admin_metadata_get. You need to use with mock.patch('cinder.db.snapshot_get') as snapshot_get, mock.patch('cinder.db.snapshot_admin_metadata_get') as snapshot_admin_metadata_get. These

Re: [openstack-dev] [cinder] [Third-party-announce] Cinder Merged patch broke HDS driver

2015-03-05 Thread Thang Pham
I commented on this in your patch (https://review.openstack.org/#/c/161837/) and posted a patch to help you along - https://review.openstack.org/#/c/161945/. This patch will make create_snapshot and create_volume_from_snapshot method use snapshot objects. By using snapshot objects in both