I don't think requiring a +1 from every single reviewer listed on the
review before merging it is reasonable.
Every day a review that is ready to be merged spends waiting means
more time spent rebasing, redoing the reviews, dealing with immediate
and hidden problems caused by changes in master
Guys,
We have big and complicated structure of the project. And part of our
patchsets require additional actions before merge. Sometimes we need
approve from testers, sometimes we need merge requests in several repos at
the same time, sometimes we need updates of rpm repositories before merge.
Humans make mistakes... all the time. Let's think how we can automate this
to have appropriate Jenkins check. In this particular case, we could do the
following:
a) make it work in progress if we still unsure on some deps
b) can we have smoke test which would check that master node builds, and
So every developer should manually mark every such review as WIP? And
remove this flag only when everyone agreed to merge? This will require
additional actions in 50% of fuel-web and 100% of fuel-main reviews.
Developers make mistakes too.
Let's just be more accurate.
On Tue, Apr 15, 2014 at
