Re: [openstack-dev] [Horizon] unit test improvements: work with DOM, not raw HTML strings?

2015-10-23 Thread Timur Sufiev
+1 here. While the exact library choice may still be a topic for the discussion, unit tests clearly shouldn't hardcode html stings inside, it is too fragile. On Fri, 23 Oct 2015 at 02:00, Diana Whitten wrote: > Richard, > > I'm absolutely with you ... I've been bitten by

Re: [openstack-dev] [Horizon] unit test improvements: work with DOM, not raw HTML strings?

2015-10-22 Thread Diana Whitten
Richard, I'm absolutely with you ... I've been bitten by these very tests recently when changing a class in a simple template. If anyone wants to override these templates in the future, then they are forced to fight this 'expected_string' test as well. I think this is a good idea. - Diana On