Hi,
I never had a strong opinion on this but reading what Jay said makes
sense to me. I also like Robert suggestion about having a single +2/+A
for such small changes.
Cheers,
Lucas
On Wed, Feb 25, 2015 at 11:22 PM, Robert Collins
robe...@robertcollins.net wrote:
On 26 February 2015 at 05:26,
On 02/26/2015 06:47 AM, Lucas Alvares Gomes wrote:
Hi,
I never had a strong opinion on this but reading what Jay said makes
sense to me. I also like Robert suggestion about having a single +2/+A
for such small changes.
+A
Cheers,
Lucas
On Wed, Feb 25, 2015 at 11:22 PM, Robert
On 02/25/2015 05:26 PM, Ruby Loo wrote:
Hi,
I was wondering what people thought about patches that only fix
grammatical issues or misspellings in comments in our code.
I can't believe I'm sending out this email, but as a group, I'd like it
if we had a similar understanding so that we treat
Ruby Loo said on Wed, Feb 25, 2015 at 11:26:56AM -0500:
I was wondering what people thought about patches that only fix grammatical
issues or misspellings in comments in our code.
For my money, a patch fixing nits has value but only if it fixes a few.
If it's a follow-up patch it should fix all
Hi,
I was wondering what people thought about patches that only fix grammatical
issues or misspellings in comments in our code.
I can't believe I'm sending out this email, but as a group, I'd like it if
we had a similar understanding so that we treat all patches in a similar
(dare I say it,
On Wed, Feb 25, 2015, at 12:36 PM, Jay Faulkner wrote:
On Feb 25, 2015, at 10:26 AM, Ruby Loo rlooya...@gmail.com wrote:
Hi,
I was wondering what people thought about patches that only fix grammatical
issues or misspellings in comments in our code.
I can't believe I'm
We've unwound the gate quite a bit, so the cost of extra patches in the
merge queue fixing trivial things (like comment spelling) is pretty low.
Honestly, I'd much rather merge functional fixes faster and not go an
extra 2 rounds of typo fixing (assuming the English is decipherable),
and merge
Jay,
I can only confirm your point of view.
I personally landed such a patch yesterday and saw it as an easy way to get
familiar with Gerrit.
My goal being to land some more complex patches in the near future.
Bernard
On Wed, Feb 25, 2015 at 12:37 PM, Doug Hellmann d...@doughellmann.com
wrote:
On 26 February 2015 at 05:26, Ruby Loo rlooya...@gmail.com wrote:
Hi,
I was wondering what people thought about patches that only fix grammatical
issues or misspellings in comments in our code.
I can't believe I'm sending out this email, but as a group, I'd like it if
we had a similar
