Re: [openstack-dev] [Murano] Murano projects pylint job

2015-05-07 Thread Filip Blaha
Hello pylint job was merged. At first we focused on refactor class code issues. Test patch set with code duplication [1]. If you have any suggestions about the job and code checks feel free to contact me. [1] https://review.openstack.org/#/c/181033/ Regards Filip On 04/02/2015 10:56 AM,

Re: [openstack-dev] [Murano] Murano projects pylint job

2015-04-03 Thread Filip Blaha
Hi Kate and Serg Thanks for your feedback. I look forward to IRC discussion on that. Regards Filip On 04/02/2015 10:56 AM, Ekaterina Chernova wrote: Hi Filip and Serg! I support the idea! Let's discuss more details in IRC and summarize everything on the next community meeting on Tuesday.

Re: [openstack-dev] [Murano] Murano projects pylint job

2015-04-02 Thread Ekaterina Chernova
Hi Filip and Serg! I support the idea! Let's discuss more details in IRC and summarize everything on the next community meeting on Tuesday. Regards, Kate. On Thu, Apr 2, 2015 at 11:31 AM, Filip Blaha wrote: > Hi Serg > > we can inspire in other projects like sahara. Important is that pylint

Re: [openstack-dev] [Murano] Murano projects pylint job

2015-04-02 Thread Filip Blaha
Hi Serg we can inspire in other projects like sahara. Important is that pylint job should produce reasonable size meaningful output. Pylint without any configuration produces huge output. So we should point out which code checks are interesting for us and configure pylint accordingly. I will

Re: [openstack-dev] [Murano] Murano projects pylint job

2015-04-01 Thread Serg Melikyan
Hi Filip, I think adding pylint job to Murano gates is an awesome idea, have you checked out how to do this? On Wed, Apr 1, 2015 at 4:03 PM, Filip Blaha wrote: > Hello > > I have noticed that some openstack projects [1] use pylint gate job. From > my point of view it could simplify code reviews

[openstack-dev] [Murano] Murano projects pylint job

2015-04-01 Thread Filip Blaha
Hello I have noticed that some openstack projects [1] use pylint gate job. From my point of view it could simplify code reviews even as non-voing job and generally it could improve code quality. Some code issues like code duplication are not easy to discover during code review so automatic jo