Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-25 Thread John Garbutt
On 25 July 2016 at 13:56, Bhor, Dinesh <dinesh.b...@nttdata.com> wrote: > > > -Original Message- > From: Sean Dague [mailto:s...@dague.net] > Sent: Monday, July 25, 2016 5:53 PM > To: openstack-dev@lists.openstack.org > Subject: Re: [openstack-dev] [Nova] Remov

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-25 Thread Daniel P. Berrange
On Mon, Jul 25, 2016 at 08:22:52AM -0400, Sean Dague wrote: > On 07/25/2016 08:05 AM, Daniel P. Berrange wrote: > > On Mon, Jul 25, 2016 at 07:57:08AM -0400, Sean Dague wrote: > >> On 07/22/2016 11:30 AM, Daniel P. Berrange wrote: > >>> On Thu, Jul 21, 2016 at 07:03:53AM -0700, Matt Riedemann

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-25 Thread Bhor, Dinesh
-Original Message- From: Sean Dague [mailto:s...@dague.net] Sent: Monday, July 25, 2016 5:53 PM To: openstack-dev@lists.openstack.org Subject: Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT) On 07/25/2016 08:05 AM, Daniel P. Berrange wrote: > On Mon,

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-25 Thread Sean Dague
On 07/25/2016 08:05 AM, Daniel P. Berrange wrote: > On Mon, Jul 25, 2016 at 07:57:08AM -0400, Sean Dague wrote: >> On 07/22/2016 11:30 AM, Daniel P. Berrange wrote: >>> On Thu, Jul 21, 2016 at 07:03:53AM -0700, Matt Riedemann wrote: On 7/21/2016 2:03 AM, Bhor, Dinesh wrote: I agree

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-25 Thread Daniel P. Berrange
On Mon, Jul 25, 2016 at 07:57:08AM -0400, Sean Dague wrote: > On 07/22/2016 11:30 AM, Daniel P. Berrange wrote: > > On Thu, Jul 21, 2016 at 07:03:53AM -0700, Matt Riedemann wrote: > >> On 7/21/2016 2:03 AM, Bhor, Dinesh wrote: > >> > >> I agree that it's not a bug. I also agree that it helps in

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-25 Thread Jay Pipes
On 07/25/2016 07:57 AM, Sean Dague wrote: On 07/22/2016 11:30 AM, Daniel P. Berrange wrote: On Thu, Jul 21, 2016 at 07:03:53AM -0700, Matt Riedemann wrote: On 7/21/2016 2:03 AM, Bhor, Dinesh wrote: I agree that it's not a bug. I also agree that it helps in some specific types of tests which

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-25 Thread Sean Dague
On 07/22/2016 11:30 AM, Daniel P. Berrange wrote: > On Thu, Jul 21, 2016 at 07:03:53AM -0700, Matt Riedemann wrote: >> On 7/21/2016 2:03 AM, Bhor, Dinesh wrote: >> >> I agree that it's not a bug. I also agree that it helps in some specific >> types of tests which are doing some kind of input

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-22 Thread Daniel P. Berrange
On Thu, Jul 21, 2016 at 07:03:53AM -0700, Matt Riedemann wrote: > On 7/21/2016 2:03 AM, Bhor, Dinesh wrote: > > Hi Nova Devs, > > > > > > > > Many times, there are a number of data sets that we have to run the same > > tests on. > > > > And, to create a different test for each data set values

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-21 Thread Matt Riedemann
On 7/21/2016 2:03 AM, Bhor, Dinesh wrote: Hi Nova Devs, Many times, there are a number of data sets that we have to run the same tests on. And, to create a different test for each data set values is time-consuming and inefficient. Data Driven Testing [1] overcomes this issue. Data-driven

Re: [openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-21 Thread Sheel Rana Insaan
Hi Dinesh Bhor, I could see a lot of projects have used this. Seems interesting. You can refer Cinder, for example. I think we should not raise bug for this. For me it's invalid. You can treat this as improvement(just to reduce test code blocks), it seems ok to go ahead even without any BP or

[openstack-dev] [Nova] Remove duplicate code using Data Driven Tests (DDT)

2016-07-21 Thread Bhor, Dinesh
Hi Nova Devs, Many times, there are a number of data sets that we have to run the same tests on. And, to create a different test for each data set values is time-consuming and inefficient. Data Driven Testing [1] overcomes this issue. Data-driven testing (DDT) is taking a test, parameterizing