[openstack-dev] [OpenStack-Dev] Logging formats and i18n

2014-12-22 Thread John Griffith
Lately (on the Cinder team at least) there's been a lot of disagreement in reviews regarding the proper way to do LOG messages correctly. Use of '%' vs ',' in the formatting of variables etc. We do have the oslo i18n guidelines page here [1], which helps a lot but there's some disagreement on a

Re: [openstack-dev] [OpenStack-Dev] Logging formats and i18n

2014-12-22 Thread Ben Nemec
On 12/22/2014 09:42 AM, John Griffith wrote: Lately (on the Cinder team at least) there's been a lot of disagreement in reviews regarding the proper way to do LOG messages correctly. Use of '%' vs ',' in the formatting of variables etc. We do have the oslo i18n guidelines page here [1],

Re: [openstack-dev] [OpenStack-Dev] Logging formats and i18n

2014-12-22 Thread John Griffith
On Mon, Dec 22, 2014 at 10:03 AM, Ben Nemec openst...@nemebean.com wrote: On 12/22/2014 09:42 AM, John Griffith wrote: Lately (on the Cinder team at least) there's been a lot of disagreement in reviews regarding the proper way to do LOG messages correctly. Use of '%' vs ',' in the formatting

Re: [openstack-dev] [OpenStack-Dev] Logging formats and i18n

2014-12-22 Thread Doug Hellmann
On Dec 22, 2014, at 12:03 PM, Ben Nemec openst...@nemebean.com wrote: On 12/22/2014 09:42 AM, John Griffith wrote: Lately (on the Cinder team at least) there's been a lot of disagreement in reviews regarding the proper way to do LOG messages correctly. Use of '%' vs ',' in the formatting of

Re: [openstack-dev] [OpenStack-Dev] Logging formats and i18n

2014-12-22 Thread Doug Hellmann
On Dec 22, 2014, at 1:05 PM, John Griffith john.griffi...@gmail.com wrote: On Mon, Dec 22, 2014 at 10:03 AM, Ben Nemec openst...@nemebean.com wrote: On 12/22/2014 09:42 AM, John Griffith wrote: Lately (on the Cinder team at least) there's been a lot of disagreement in reviews regarding the