[openstack-dev] [Solum] Dissecting the very first review

2013-11-01 Thread Noorul Islam K M
Now we have the first patch [1] merged into the repository using OpenStack review process. I would like to bring into notice some minor issues. First of all I would like to thank [2] Swapnil for fixing the patch. 1. Look at patch set 3 and it changed the Author and also the Committer. I am

Re: [openstack-dev] [Solum] Dissecting the very first review

2013-11-01 Thread Clark Boylan
On Fri, Nov 1, 2013 at 6:29 PM, Noorul Islam K M noo...@noorul.com wrote: Now we have the first patch [1] merged into the repository using OpenStack review process. I would like to bring into notice some minor issues. First of all I would like to thank [2] Swapnil for fixing the patch. 1.

Re: [openstack-dev] [Solum] Dissecting the very first review

2013-11-01 Thread Noorul Islam K M
Clark Boylan clark.boy...@gmail.com writes: On Fri, Nov 1, 2013 at 6:29 PM, Noorul Islam K M noo...@noorul.com wrote: Now we have the first patch [1] merged into the repository using OpenStack review process. I would like to bring into notice some minor issues. First of all I would like

Re: [openstack-dev] [Solum] Dissecting the very first review

2013-11-01 Thread Adrian Otto
On Nov 1, 2013, at 7:03 PM, Noorul Islam K M noo...@noorul.commailto:noo...@noorul.com wrote: Clark Boylan clark.boy...@gmail.commailto:clark.boy...@gmail.com writes: On Fri, Nov 1, 2013 at 6:29 PM, Noorul Islam K M noo...@noorul.commailto:noo...@noorul.com wrote: Now we have the first