Most projects follow a review rule that a patch needs 2 +2s before being
approved. I suggest we do the same for Solum. I bring it up since I've
noticed some inconsistency with this so far.
Thanks,
--
Russell Bryant
___
OpenStack-dev mailing list
On 11/18/2013 08:56 AM, Russell Bryant wrote:
Most projects follow a review rule that a patch needs 2 +2s before being
approved. I suggest we do the same for Solum. I bring it up since I've
noticed some inconsistency with this so far.
+2.
-jay
On 11/18/2013 07:31 AM, Jay Pipes wrote:
On 11/18/2013 08:56 AM, Russell Bryant wrote:
Most projects follow a review rule that a patch needs 2 +2s before being
approved. I suggest we do the same for Solum. I bring it up since I've
noticed some inconsistency with this so far.
+2.
+2/+A
.
--
Adrian
Original message
From: Russell Bryant
Date:11/18/2013 6:01 AM (GMT-08:00)
To: OpenStack Development Mailing List
Subject: [openstack-dev] [Solum] code review, 2 +2s?
Most projects follow a review rule that a patch needs 2 +2s before being
approved. I suggest we do
