Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-10 Thread Tony Breeds
On Fri, Nov 11, 2016 at 12:08:04PM +1300, Robert Collins wrote: > On 10 Nov 2016 9:29 PM, "Tony Breeds" wrote: > > > > On Thu, Nov 10, 2016 at 08:48:16PM +1300, Robert Collins wrote: > > > > > We generate multiline constraints whenever versions are different > > > between

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-10 Thread Robert Collins
On 10 Nov 2016 9:29 PM, "Tony Breeds" wrote: > > On Thu, Nov 10, 2016 at 08:48:16PM +1300, Robert Collins wrote: > > > We generate multiline constraints whenever versions are different > > between python 2 and 3 for the same package. That was happening when I > > wrote

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-10 Thread Tony Breeds
On Thu, Nov 10, 2016 at 08:48:16PM +1300, Robert Collins wrote: > We generate multiline constraints whenever versions are different > between python 2 and 3 for the same package. That was happening when I > wrote the tool in the first place - it was one of the reasons I wrote > edit-constraints,

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-09 Thread Robert Collins
On 10 November 2016 at 11:00, Tony Breeds wrote: > On Thu, Nov 10, 2016 at 06:17:44AM +1300, Robert Collins wrote: >> Sed doesn't exist on windows, whereas a python script can. Sed doesn't >> handle multiple line constraints. > > I don't think that right now we

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-09 Thread Tony Breeds
On Wed, Nov 09, 2016 at 12:00:27PM +0100, Ihar Hrachyshka wrote: > I believe sed is the way to go. There is not much we get from > edit-constraints at this point, and it untangles the script from zuul-cloner > that would be needed to fetch requirements repo. > > It seems like the way to go.

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-09 Thread Tony Breeds
On Thu, Nov 10, 2016 at 06:17:44AM +1300, Robert Collins wrote: > Sed doesn't exist on windows, whereas a python script can. Sed doesn't > handle multiple line constraints. I don't think that right now we care/handle multiline constraints but the windows think is important and not something I

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-09 Thread Robert Collins
Sed doesn't exist on windows, whereas a python script can. Sed doesn't handle multiple line constraints. Rob On 10 Nov 2016 12:00 AM, "Ihar Hrachyshka" wrote: > > > On 8 Nov 2016, at 04:07, Tony Breeds wrote: > > > > On Sat, Sep 03, 2016 at

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-09 Thread Ihar Hrachyshka
> On 8 Nov 2016, at 04:07, Tony Breeds wrote: > > On Sat, Sep 03, 2016 at 07:33:42PM +0200, Andreas Jaeger wrote: >> Reviewing all the constraints work, I see that repositories have created >> some workaround around requirements install for one of these two legimit >>

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-11-07 Thread Tony Breeds
On Sat, Sep 03, 2016 at 07:33:42PM +0200, Andreas Jaeger wrote: > Reviewing all the constraints work, I see that repositories have created > some workaround around requirements install for one of these two legimit > reasons - most often using tools/tox_install.sh from tox.ini for it: > > 1) The

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-09-05 Thread Ihar Hrachyshka
Andreas Jaeger wrote: On 09/05/2016 07:45 AM, Tony Breeds wrote: On Sat, Sep 03, 2016 at 07:33:42PM +0200, Andreas Jaeger wrote: Reviewing all the constraints work, I see that repositories have created some workaround around requirements install for one of these two legimit

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-09-05 Thread Akihiro Motoki
2016-09-05 16:03 GMT+09:00 Andreas Jaeger : > On 09/05/2016 07:45 AM, Tony Breeds wrote: >> On Sat, Sep 03, 2016 at 07:33:42PM +0200, Andreas Jaeger wrote: >>> Reviewing all the constraints work, I see that repositories have created >>> some workaround around requirements install

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-09-05 Thread Andreas Jaeger
On 09/05/2016 07:45 AM, Tony Breeds wrote: > On Sat, Sep 03, 2016 at 07:33:42PM +0200, Andreas Jaeger wrote: >> Reviewing all the constraints work, I see that repositories have created >> some workaround around requirements install for one of these two legimit >> reasons - most often using

Re: [openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-09-04 Thread Tony Breeds
On Sat, Sep 03, 2016 at 07:33:42PM +0200, Andreas Jaeger wrote: > Reviewing all the constraints work, I see that repositories have created > some workaround around requirements install for one of these two legimit > reasons - most often using tools/tox_install.sh from tox.ini for it: > > 1) The

[openstack-dev] [all][infra][requirements] Odd cases in requirements?

2016-09-03 Thread Andreas Jaeger
Reviewing all the constraints work, I see that repositories have created some workaround around requirements install for one of these two legimit reasons - most often using tools/tox_install.sh from tox.ini for it: 1) The repository is a dependency of another one and uses constraints, so edit