Re: [openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-25 Thread Radomir Dopieralski
I prepared a patch that forces the use of 2.40 api version if it's available for that particular endpoint. Instead of waiting for the microversion patch, I simply copied the needed fragments from it -- we can fix that later once we have proper microversion support implemented.

Re: [openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-24 Thread Diana Clarke
It was done like that to circumvent the existing possibility DoS-like usage requests when there are thousands of instances. Some of the history behind that decision can be found in the spec discussions [1]. And an easier to read spec can be found here [2]. [1]

Re: [openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-24 Thread Radomir Dopieralski
No, for some reason Nova will now always limit the number of entries it sends in a single response, no matter what microversion you use. If you use microversion of at least 2.40, it will let you request more responses, to get all the entries. I don't know why they did it like that. On Tue, Jan

Re: [openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-24 Thread Rob Cresswell (rcresswe)
As I understand it, if someone configures Nova to use 2.40 via settings, then it will use 2.40 for every request. This could likely break Horizon in weird ways, which makes it seem risky to try and support it. What I don’t really understand about this FFE, is why we need to modify the

Re: [openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-23 Thread Richard Jones
[I'm on vacation, so can't look into this too deeply, sorry] I'm not sure I follow Rob's point here. Does the patch https://review.openstack.org/#/c/410337 just check the version to see if it's >= 2.40 and take action appropriately? I don't see how it changes anything to force requesting 2.40

Re: [openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-23 Thread Radomir Dopieralski
Yes, to do it differently we need to add the microversion support patch that you are working on, and make use of it, or write a patch that has equivalent functionality. On Fri, Jan 20, 2017 at 6:57 PM, Rob Cresswell wrote: > Just a thought: With the way we

Re: [openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-20 Thread Rob Cresswell
Just a thought: With the way we currently do microversions, wouldnt this request 2.40 for every request ? There's a pretty good chance that would break things. Rob On 20 January 2017 at 00:02, Richard Jones > wrote: FFE granted for the

Re: [openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-19 Thread Richard Jones
FFE granted for the three patches. We need to support that nova API change. On 20 January 2017 at 01:28, Radomir Dopieralski wrote: > I would like to request a feature freeze exception for the following patch: > > https://review.openstack.org/#/c/410337 > > This patch

[openstack-dev] [horizon] feature freeze exception request -- nova simple tenant usages api pagination

2017-01-19 Thread Radomir Dopieralski
I would like to request a feature freeze exception for the following patch: https://review.openstack.org/#/c/410337 This patch adds support for retrieving the simple tenant usages from Nova in chunks, and it is necessary for correct data given that related patches have been already merged in