Re: [openstack-dev] [ironic] Translations removal

2017-04-05 Thread Dmitry Tantsur
On 03/30/2017 08:36 PM, Doug Hellmann wrote: Excerpts from Sean McGinnis's message of 2017-03-22 10:44:05 -0500: On Wed, Mar 22, 2017 at 08:42:42AM -0500, Kevin L. Mitchell wrote: On Tue, 2017-03-21 at 22:10 +, Taryma, Joanna wrote: However, pep8 does not accept passing variable to

Re: [openstack-dev] [ironic] Translations removal

2017-04-03 Thread Jim Rollenhagen
On Thu, Mar 30, 2017 at 3:24 PM, Doug Hellmann wrote: > Excerpts from Jim Rollenhagen's message of 2017-03-30 15:08:13 -0400: > > On Thu, Mar 30, 2017 at 2:36 PM, Doug Hellmann > > wrote: > > > > > Excerpts from Sean McGinnis's message of 2017-03-22

Re: [openstack-dev] [ironic] Translations removal

2017-03-30 Thread Doug Hellmann
Excerpts from Jim Rollenhagen's message of 2017-03-30 15:08:13 -0400: > On Thu, Mar 30, 2017 at 2:36 PM, Doug Hellmann > wrote: > > > Excerpts from Sean McGinnis's message of 2017-03-22 10:44:05 -0500: > > > On Wed, Mar 22, 2017 at 08:42:42AM -0500, Kevin L. Mitchell

Re: [openstack-dev] [ironic] Translations removal

2017-03-30 Thread Jim Rollenhagen
On Thu, Mar 30, 2017 at 2:36 PM, Doug Hellmann wrote: > Excerpts from Sean McGinnis's message of 2017-03-22 10:44:05 -0500: > > On Wed, Mar 22, 2017 at 08:42:42AM -0500, Kevin L. Mitchell wrote: > > > On Tue, 2017-03-21 at 22:10 +, Taryma, Joanna wrote: > > > >

Re: [openstack-dev] [ironic] Translations removal

2017-03-30 Thread Doug Hellmann
Excerpts from Sean McGinnis's message of 2017-03-22 10:44:05 -0500: > On Wed, Mar 22, 2017 at 08:42:42AM -0500, Kevin L. Mitchell wrote: > > On Tue, 2017-03-21 at 22:10 +, Taryma, Joanna wrote: > > > However, pep8 does not accept passing variable to translation > > > functions, so this

Re: [openstack-dev] [ironic] Translations removal

2017-03-23 Thread Jim Rollenhagen
On Wed, Mar 22, 2017 at 11:44 AM, Sean McGinnis wrote: > On Wed, Mar 22, 2017 at 08:42:42AM -0500, Kevin L. Mitchell wrote: > > On Tue, 2017-03-21 at 22:10 +, Taryma, Joanna wrote: > > > However, pep8 does not accept passing variable to translation > > > functions, so

Re: [openstack-dev] [ironic] Translations removal

2017-03-22 Thread Kevin L. Mitchell
On Wed, 2017-03-22 at 18:44 +, Taryma, Joanna wrote: > Thanks for pointing out that 2 and 3 won’t actually work, I apologize > for the confusion it could’ve created. > > > > I don’t like the option 6, because making user-messages friendlier was > the whole purpose of translation. Mixing

Re: [openstack-dev] [ironic] Translations removal

2017-03-22 Thread Taryma, Joanna
e questions)" <openstack-dev@lists.openstack.org> Date: Wednesday, March 22, 2017 at 7:54 AM To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [ironic] Translations removal HI all, my 5 c

Re: [openstack-dev] [ironic] Translations removal

2017-03-22 Thread Tom Barron
On 03/22/2017 11:44 AM, Sean McGinnis wrote: > On Wed, Mar 22, 2017 at 08:42:42AM -0500, Kevin L. Mitchell wrote: >> On Tue, 2017-03-21 at 22:10 +, Taryma, Joanna wrote: >>> However, pep8 does not accept passing variable to translation >>> functions, so this results in ‘H701 Empty

Re: [openstack-dev] [ironic] Translations removal

2017-03-22 Thread Sean McGinnis
On Wed, Mar 22, 2017 at 08:42:42AM -0500, Kevin L. Mitchell wrote: > On Tue, 2017-03-21 at 22:10 +, Taryma, Joanna wrote: > > However, pep8 does not accept passing variable to translation > > functions, so this results in ‘H701 Empty localization string’ error. > > > > Possible options to

Re: [openstack-dev] [ironic] Translations removal

2017-03-22 Thread Pavlo Shchelokovskyy
HI all, my 5 cents: - option 1) is ugly due to code/string duplication; - options 2) and 3) are not going to work for translators as others already pointed; - option 4) has a caveat that we should do it consistently - either translate all or translate none, so there won't be a mess of log

Re: [openstack-dev] [ironic] Translations removal

2017-03-22 Thread Lucas Alvares Gomes
Hi, >> Possible options to handle that: >> >> 1) Duplicate messages: >> >> LOG.error(“”, {: }) >> >> raise Exception(_(“”) % {: }) >> >> 2) Ignore this error >> >> 3) Talk to hacking people about possible upgrade of this check >> >> 4) Pass translated text to LOG in such cases

Re: [openstack-dev] [ironic] Translations removal

2017-03-22 Thread Kevin L. Mitchell
On Tue, 2017-03-21 at 22:10 +, Taryma, Joanna wrote: > However, pep8 does not accept passing variable to translation > functions, so this results in ‘H701 Empty localization string’ error. > > Possible options to handle that: > > 1) Duplicate messages: > > LOG.error(“”, {: }) > >

Re: [openstack-dev] [ironic] Translations removal

2017-03-22 Thread Vladyslav Drok
On Wed, Mar 22, 2017 at 12:10 AM, Taryma, Joanna wrote: > Hi team, > > > > As discussed on Monday, logged messages shouldn’t be translated anymore. > Exception messages still should be still translated. > > While removing usages of _LE, _LW, _LI should be fairly easy,

[openstack-dev] [ironic] Translations removal

2017-03-21 Thread Taryma, Joanna
Hi team, As discussed on Monday, logged messages shouldn’t be translated anymore. Exception messages still should be still translated. While removing usages of _LE, _LW, _LI should be fairly easy, some usages of _ may cause issues. Some messages in the code are declared with ‘_’ method and