Re: [openstack-dev] [neutron] Adding results to extension callbacks (ml2 port_update ext handling).

2015-07-15 Thread Irena Berezovsky
Hi Bob, Miguel On Tue, Jul 14, 2015 at 5:19 PM, Robert Kukura kuk...@noironetworks.com wrote: I haven't had a chance to review this patch in detail yet, but am wondering if this is being integrated with ML2 as an extension driver? If so, that should clearly address how dictionaries are

Re: [openstack-dev] [neutron] Adding results to extension callbacks (ml2 port_update ext handling).

2015-07-14 Thread Robert Kukura
I haven't had a chance to review this patch in detail yet, but am wondering if this is being integrated with ML2 as an extension driver? If so, that should clearly address how dictionaries are extended and input values are validated. If not, why? -Bob On 7/13/15 10:50 PM, Miguel Angel Ajo

Re: [openstack-dev] [neutron] Adding results to extension callbacks (ml2 port_update ext handling).

2015-07-13 Thread Miguel Angel Ajo
Inline reply (I've added to CC relevant people for ml2/plugin.py port_update extension handing -via git blame-) as they probably have an opinion here (specially the last two options). Kevin Benton wrote: This sounds like a lot of overlap with the dict extend functions. Why weren't they

[openstack-dev] [neutron] Adding results to extension callbacks

2015-07-13 Thread Mike Kolesnik
Hi, I sent a simple patch to check the possibility to add results to callbacks: https://review.openstack.org/#/c/201127/ This will allow us to decouple the callback logic from the ML2 plugin in the QoS scenario where we need to update the agents in case the profile_id on a port/network

Re: [openstack-dev] [neutron] Adding results to extension callbacks

2015-07-13 Thread Kevin Benton
This sounds like a lot of overlap with the dict extend functions. Why weren't they adequate for the QoS use case? On Mon, Jul 13, 2015 at 7:58 AM, Mike Kolesnik mkole...@redhat.com wrote: Hi, I sent a simple patch to check the possibility to add results to callbacks: