Re: [openstack-dev] [nova][cinder][glance] What should be the response for invalid 'Accpet' header?

2017-09-04 Thread Erno Kuvaja
On Fri, Sep 1, 2017 at 6:53 PM, Chris Dent wrote: > On Fri, 1 Sep 2017, Sean McGinnis wrote: > >> Thanks Chris, I wasn't aware of that. What's your opinion - change >> it to be more strict, or leave it as is? > > > Ideally we'd have true content negotiation and support

Re: [openstack-dev] [nova][cinder][glance] What should be the response for invalid 'Accpet' header?

2017-09-01 Thread Chris Dent
On Fri, 1 Sep 2017, Sean McGinnis wrote: Thanks Chris, I wasn't aware of that. What's your opinion - change it to be more strict, or leave it as is? Ideally we'd have true content negotiation and support multiple representations with different content types and diferent versions. ;)/2 But

Re: [openstack-dev] [nova][cinder][glance] What should be the response for invalid 'Accpet' header?

2017-09-01 Thread Sean McGinnis
However, this isn't violating the HTTP 1.1 RFCs. https://tools.ietf.org/html/rfc7231#section-5.3.2 says: "If the header field is present in a request and none of the available representations for the response have a media type that is listed as acceptable, the origin server can either honor

Re: [openstack-dev] [nova][cinder][glance] What should be the response for invalid 'Accpet' header?

2017-09-01 Thread Chris Dent
On Thu, 31 Aug 2017, Singh, Niraj wrote: As of now, when user passes 'Accept' header in request other than JSON and XML using curl command then it returns 200 OK response with json format data. In api-ref guide [1] also it's not clearly mentioned about what response it should return if

Re: [openstack-dev] [nova][cinder][glance] What should be the response for invalid 'Accpet' header?

2017-08-31 Thread Singh, Niraj
] [nova][cinder][glance] What should be the response for invalid 'Accpet' header? Hey Niraj, That does seem to be incorrect behavior on the services side. It would be good to have a bug filed to track it. For now you could open one and flag each project as being affected. We may find

Re: [openstack-dev] [nova][cinder][glance] What should be the response for invalid 'Accpet' header?

2017-08-31 Thread Sean McGinnis
Hey Niraj, That does seem to be incorrect behavior on the services side. It would be good to have a bug filed to track it. For now you could open one and flag each project as being affected. We may find that it requires a change in each project, or it may end up being a common oslo change.

[openstack-dev] [nova][cinder][glance] What should be the response for invalid 'Accpet' header?

2017-08-31 Thread Singh, Niraj
Hi Devs, As of now, when user passes 'Accept' header in request other than JSON and XML using curl command then it returns 200 OK response with json format data. In api-ref guide [1] also it's not clearly mentioned about what response it should return if invalid value for 'Accept' header is