Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-31 Thread Matt Riedemann
On 3/31/2016 5:58 AM, Duncan Thomas wrote: I *think* it is significantly semanticist different to do detach, attach; with swap volume, no events are generated in the guest; that is why it is dangerous to expose to the tenant - if the volume contents is not identical, you get weird corruption

Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-31 Thread Duncan Thomas
I *think* it is significantly semanticist different to do detach, attach; with swap volume, no events are generated in the guest; that is why it is dangerous to expose to the tenant - if the volume contents is not identical, you get weird corruption as the guess flushes caches. I think this call

Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-31 Thread GHANSHYAM MANN
This [1] adds tests for swap volume with admin and non-admin case. I want to check behaviour with current code so not adding Depends-On on your fix. Once we have gate results then feel free to add Depends-On or I will add. I think virt driver does not do attach/detach but we can re-verify that on

Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-30 Thread Matt Riedemann
On 3/30/2016 9:14 PM, GHANSHYAM MANN wrote: On Thu, Mar 31, 2016 at 10:39 AM, Matt Riedemann wrote: On 3/30/2016 8:20 PM, Matt Riedemann wrote: On 3/30/2016 7:56 PM, Matt Riedemann wrote: On 3/30/2016 7:38 PM, Matt Riedemann wrote: On 2/25/2016 5:31

Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-30 Thread GHANSHYAM MANN
On Thu, Mar 31, 2016 at 10:39 AM, Matt Riedemann wrote: > > > On 3/30/2016 8:20 PM, Matt Riedemann wrote: >> >> >> >> On 3/30/2016 7:56 PM, Matt Riedemann wrote: >>> >>> >>> >>> On 3/30/2016 7:38 PM, Matt Riedemann wrote: On 2/25/2016 5:31 AM,

Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-30 Thread Matt Riedemann
On 3/30/2016 8:20 PM, Matt Riedemann wrote: On 3/30/2016 7:56 PM, Matt Riedemann wrote: On 3/30/2016 7:38 PM, Matt Riedemann wrote: On 2/25/2016 5:31 AM, Takashi Natsume wrote: Hi Nova and Cinder developers. As I reported in a bug report [1], nova swap volume (updating an attached

Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-30 Thread Matt Riedemann
On 3/30/2016 7:56 PM, Matt Riedemann wrote: On 3/30/2016 7:38 PM, Matt Riedemann wrote: On 2/25/2016 5:31 AM, Takashi Natsume wrote: Hi Nova and Cinder developers. As I reported in a bug report [1], nova swap volume (updating an attached volume) fuction does not work in the case of non

Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-30 Thread Matt Riedemann
On 3/30/2016 7:38 PM, Matt Riedemann wrote: On 2/25/2016 5:31 AM, Takashi Natsume wrote: Hi Nova and Cinder developers. As I reported in a bug report [1], nova swap volume (updating an attached volume) fuction does not work in the case of non admin users by default. (Volumes are stuck.)

Re: [openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-03-30 Thread Matt Riedemann
On 2/25/2016 5:31 AM, Takashi Natsume wrote: Hi Nova and Cinder developers. As I reported in a bug report [1], nova swap volume (updating an attached volume) fuction does not work in the case of non admin users by default. (Volumes are stuck.) Before I was working for fixing another swap

[openstack-dev] [nova][cinder] Fix nova swap volume (updating an attached volume) function

2016-02-25 Thread Takashi Natsume
Hi Nova and Cinder developers. As I reported in a bug report [1], nova swap volume (updating an attached volume) fuction does not work in the case of non admin users by default. (Volumes are stuck.) Before I was working for fixing another swap volume bug [2][3]. But Ryan fixed it on the Cinder