Re: [openstack-dev] [nova][compute] propose to use a table to deal with the vm_state when _init_instance in compute

2014-11-04 Thread Alex Xu
+1, good idea! 2014-11-04 15:15 GMT+08:00 Eli Qiao ta...@linux.vnet.ibm.com: hello all: in current _init_instance function in compute manager, there's flood 'and' 'or' logic, to check the vm_state and task_state when initialize a instance during service list, this lead hard to read and

[openstack-dev] [nova][compute] propose to use a table to deal with the vm_state when _init_instance in compute

2014-11-03 Thread Eli Qiao
hello all: in current _init_instance function in compute manager, there's flood 'and' 'or' logic, to check the vm_state and task_state when initialize a instance during service list, this lead hard to read and hard to maintain, so I propose a new way to handle this. we can create a

Re: [openstack-dev] [nova][compute] propose to use a table to deal with the vm_state when _init_instance in compute

2014-11-03 Thread Chen CH Ji
+1, a good idea, it will make it more clear. from implementation perspective we need to pay attention that some status will pass through and some will just return Best Regards! Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com

Re: [openstack-dev] [nova][compute] propose to use a table to deal with the vm_state when _init_instance in compute

2014-11-03 Thread Eli Qiao
? 2014?11?04? 15:19, Chen CH Ji ??: +1, a good idea, it will make it more clear. from implementation perspective we need to pay attention that some status will pass through and some will just return Best Regards! hi Kevin thanks for supporting. yeah, I am considering vm_state first, it