Re: [openstack-dev] [nova] [placement] [api] cache headers in placement service

2017-08-23 Thread Chris Dent
On Mon, 21 Aug 2017, Chris Dent wrote: Essentially so we can put last-modified headers on things, which in RFC speak we SHOULD do. And if we do that then we SHOULD make sure no caching happens. For sake of completeness, I've gone ahead and proposed a spec for this:

Re: [openstack-dev] [nova] [placement] [api] cache headers in placement service

2017-08-21 Thread Mooney, Sean K
> -Original Message- > From: Chris Dent [mailto:cdent...@anticdent.org] > Sent: Monday, August 21, 2017 10:44 AM > To: OpenStack Development Mailing List (not for usage questions) > <openstack-dev@lists.openstack.org> > Subject: Re: [openstack-dev] [nova] [placem

Re: [openstack-dev] [nova] [placement] [api] cache headers in placement service

2017-08-21 Thread Chris Dent
On Mon, 21 Aug 2017, Jay Pipes wrote: On 08/21/2017 04:59 AM, Chris Dent wrote: We do have cache validation on the server side for resource classes. Any time a resource class is added or deleted, we call _RC_CACHE.clear(). Couldn't we add a single attribute to the ResourceClassCache that

Re: [openstack-dev] [nova] [placement] [api] cache headers in placement service

2017-08-21 Thread Jay Pipes
On 08/21/2017 04:59 AM, Chris Dent wrote: On Sun, 20 Aug 2017, Jay Pipes wrote: On 08/18/2017 01:23 PM, Chris Dent wrote: So my change above adds 'last-modified' and 'cache-control: no-cache' to GET of /resource_providers and /resource_providers/{uuid} and proposes we do it for everything

Re: [openstack-dev] [nova] [placement] [api] cache headers in placement service

2017-08-21 Thread Chris Dent
On Sun, 20 Aug 2017, Jay Pipes wrote: On 08/18/2017 01:23 PM, Chris Dent wrote: So my change above adds 'last-modified' and 'cache-control: no-cache' to GET of /resource_providers and /resource_providers/{uuid} and proposes we do it for everything else. Should we? No. :) Not everything. In

Re: [openstack-dev] [nova] [placement] [api] cache headers in placement service

2017-08-20 Thread Jay Pipes
Hi Chris, thanks for taking this on. Comments inline. On 08/18/2017 01:23 PM, Chris Dent wrote: (I put [api] in the subject tags because this might be of interest to a wider audience that cares about APIs.) Long ago and far away I made this bug:

[openstack-dev] [nova] [placement] [api] cache headers in placement service

2017-08-18 Thread Chris Dent
(I put [api] in the subject tags because this might be of interest to a wider audience that cares about APIs.) Long ago and far away I made this bug: https://bugs.launchpad.net/nova/+bug/1632852 "placement api responses should not be cacehable" Today I've pushed up a WIP that