Re: [openstack-dev] [puppet] Parameters possible default value

2015-09-07 Thread Yanis Guenane
Hello, Few weeks ago the patches needed for us to have a cleaner parameters default management way of doing things have been merged [1]. After that each module have been updated so it could rely on this new feature. All but puppet-neutron[3] and puppet-glance[4] have their patch merged.

Re: [openstack-dev] [puppet] Parameters possible default value

2015-08-06 Thread Yanis Guenane
Hi Andrew, Sorry for the delay in this answer On 07/30/2015 09:20 PM, Andrew Woodward wrote: On Thu, Jul 30, 2015 at 3:36 AM Sebastien Badia sba...@redhat.com wrote: On Mon, Jul 27, 2015 at 09:43:28PM (+), Andrew Woodward wrote: Sorry, I forgot to finish this up and send it out.

Re: [openstack-dev] [puppet] Parameters possible default value

2015-07-30 Thread Andrew Woodward
On Thu, Jul 30, 2015 at 3:36 AM Sebastien Badia sba...@redhat.com wrote: On Mon, Jul 27, 2015 at 09:43:28PM (+), Andrew Woodward wrote: Sorry, I forgot to finish this up and send it out. #--SNIP-- def absent_default( $value, $default, $unset_when_default = true, ){

Re: [openstack-dev] [puppet] Parameters possible default value

2015-07-30 Thread Sebastien Badia
On Mon, Jul 27, 2015 at 09:43:28PM (+), Andrew Woodward wrote: Sorry, I forgot to finish this up and send it out. #--SNIP-- def absent_default( $value, $default, $unset_when_default = true, ){ if ( $value == $default ) and $unset_when_default { # I cant think of a way to

Re: [openstack-dev] [puppet] Parameters possible default value

2015-07-27 Thread Andrew Woodward
Sorry, I forgot to finish this up and send it out. #--SNIP-- def absent_default( $value, $default, $unset_when_default = true, ){ if ( $value == $default ) and $unset_when_default { # I cant think of a way to deal with this in a define so lets pretend # we can re-use this with

Re: [openstack-dev] [puppet] Parameters possible default value

2015-07-27 Thread Yanis Guenane
On 07/20/2015 10:07 AM, Martin Mágr wrote: Hey Yanis On 07/17/2015 10:56 AM, Yanis Guenane wrote: Hello everyone, if set the value would have been set else it would default to upstream default. But Mathieu raised a fair point here[2] is that an empty string for some settings is a

Re: [openstack-dev] [puppet] Parameters possible default value

2015-07-20 Thread Martin Mágr
Hey Yanis On 07/17/2015 10:56 AM, Yanis Guenane wrote: Hello everyone, if set the value would have been set else it would default to upstream default. But Mathieu raised a fair point here[2] is that an empty string for some settings is a valid value, and hence we can't rely on it. Since

[openstack-dev] [puppet] Parameters possible default value

2015-07-17 Thread Yanis Guenane
Hello everyone, Based on the conversation we had during last meeting I went ahead and created an ini_setting provider[1] that will act as a proxy between our provider and the upstream one, this way we don't have to fork, only overload the method we want. The second step towards parameter

Re: [openstack-dev] [puppet] Parameters possible default value

2015-07-17 Thread Alex Schultz
Hey Yanis, On Fri, Jul 17, 2015 at 3:56 AM, Yanis Guenane yguen...@redhat.com wrote: Hello everyone, Based on the conversation we had during last meeting I went ahead and created an ini_setting provider[1] that will act as a proxy between our provider and the upstream one, this way we