Re: [openstack-dev] [qa][tempest] Where to do response body validation

2014-03-13 Thread Christopher Yeoh
On Thu, 13 Mar 2014 08:17:50 +0200 Valeriy Ponomaryov wrote: > I disagree to moving this logic to "tempest/services/*". The idea of > these modules - assemble requests and return responses. Testing and > verification should be wrapped over it. Either base class or tests, > it depends on situation

Re: [openstack-dev] [qa][tempest] Where to do response body validation

2014-03-13 Thread Christopher Yeoh
ck Development Mailing List > > Subject: [openstack-dev] [qa][tempest] Where to do response body > > validation > > > > The new tempest body response validation is being added to > > individual testcases. See this as an example: > > > > https://review.opensta

Re: [openstack-dev] [qa][tempest] Where to do response body validation

2014-03-12 Thread Kenichi Oomichi
Hi Chris, Thank you for picking it up, > -Original Message- > From: Christopher Yeoh [mailto:cbky...@gmail.com] > Sent: Thursday, March 13, 2014 1:56 PM > To: OpenStack Development Mailing List > Subject: [openstack-dev] [qa][tempest] Where to do response body validati

Re: [openstack-dev] [qa][tempest] Where to do response body validation

2014-03-12 Thread Valeriy Ponomaryov
I disagree to moving this logic to "tempest/services/*". The idea of these modules - assemble requests and return responses. Testing and verification should be wrapped over it. Either base class or tests, it depends on situation... -- Kind Regards Valeriy Ponomaryov On Thu, Mar 13, 2014 at 6:55

[openstack-dev] [qa][tempest] Where to do response body validation

2014-03-12 Thread Christopher Yeoh
Hi, The new tempest body response validation is being added to individual testcases. See this as an example: https://review.openstack.org/#/c/78149 After having a look at https://review.openstack.org/#/c/80174/ I'm now thinking that perhaps we should be doing the response validation in the temp