Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-08-01 Thread Ken'ichi Ohmichi
Hi Jordan, Thanks for pointing this up:-) Your point is right for current nova situation. Nova API continues changing with small steps. The kwargs changes of tempest will help us to avoid a lot of changes in long-term. I also am happy if getting opinions from the others. Thanks for your help and

Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-31 Thread Jordan Pittier
Hi, So after I took a lot at Ken'ichi's recent proposed changes, I think this is the good approach. The kwargs approach has the good benefit of being generic so that if a consumer (say Nova) of the client class wants to add a new parameter to one of its API, it can do it without the need of updatin

Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-10 Thread Ken'ichi Ohmichi
Hi Anne, 2015-07-09 12:22 GMT+09:00 Anne Gentle : > On Wed, Jul 8, 2015 at 9:48 PM, GHANSHYAM MANN > wrote: >> On Thu, Jul 9, 2015 at 9:39 AM, Ken'ichi Ohmichi >> wrote: >> > 2015-07-08 16:42 GMT+09:00 Ken'ichi Ohmichi : >> >> 2015-07-08 14:07 GMT+09:00 GHANSHYAM MANN : >> >>> On Wed, Jul 8, 201

Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-08 Thread Anne Gentle
On Wed, Jul 8, 2015 at 9:48 PM, GHANSHYAM MANN wrote: > On Thu, Jul 9, 2015 at 9:39 AM, Ken'ichi Ohmichi > wrote: > > 2015-07-08 16:42 GMT+09:00 Ken'ichi Ohmichi : > >> 2015-07-08 14:07 GMT+09:00 GHANSHYAM MANN : > >>> On Wed, Jul 8, 2015 at 12:27 PM, Ken'ichi Ohmichi < > ken1ohmi...@gmail.com>

Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-08 Thread GHANSHYAM MANN
On Thu, Jul 9, 2015 at 9:39 AM, Ken'ichi Ohmichi wrote: > 2015-07-08 16:42 GMT+09:00 Ken'ichi Ohmichi : >> 2015-07-08 14:07 GMT+09:00 GHANSHYAM MANN : >>> On Wed, Jul 8, 2015 at 12:27 PM, Ken'ichi Ohmichi >>> wrote: By defining all parameters on each method like update_quota_set(), it

Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-08 Thread Rochelle Grober
Ken'ichi Ohmichi wrote: 2015-07-08 16:42 GMT+09:00 Ken'ichi Ohmichi : > 2015-07-08 14:07 GMT+09:00 GHANSHYAM MANN : >> On Wed, Jul 8, 2015 at 12:27 PM, Ken'ichi Ohmichi >> wrote: >>> >>> By defining all parameters on each method like update_quota_set(), it >>> is easy to know what parameters a

Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-08 Thread Ken'ichi Ohmichi
2015-07-08 16:42 GMT+09:00 Ken'ichi Ohmichi : > 2015-07-08 14:07 GMT+09:00 GHANSHYAM MANN : >> On Wed, Jul 8, 2015 at 12:27 PM, Ken'ichi Ohmichi >> wrote: >>> >>> By defining all parameters on each method like update_quota_set(), it >>> is easy to know what parameters are available from caller/pr

Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-08 Thread Ken'ichi Ohmichi
Hi Ghansyham, Thank you for your comment. 2015-07-08 14:07 GMT+09:00 GHANSHYAM MANN : > On Wed, Jul 8, 2015 at 12:27 PM, Ken'ichi Ohmichi > wrote: >> >> By defining all parameters on each method like update_quota_set(), it >> is easy to know what parameters are available from caller/programer >

Re: [openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-07 Thread GHANSHYAM MANN
On Wed, Jul 8, 2015 at 12:27 PM, Ken'ichi Ohmichi wrote: > Hi tempest team, > > We are working for refactoring service clients in tempest for > preparing to migrate them to tempest-lib, and I found an inconsistency > between them. > So I'd like to ask opinions for considering which is the best as

[openstack-dev] [qa][tempest] "kwargs" of service clients for POST/PUT methods

2015-07-07 Thread Ken'ichi Ohmichi
Hi tempest team, We are working for refactoring service clients in tempest for preparing to migrate them to tempest-lib, and I found an inconsistency between them. So I'd like to ask opinions for considering which is the best as library methods. On some methods, a caller can specify whole body fo