Re: [openstack-dev] [Fuel] network_metadata hash keys on astute.yaml

2016-03-15 Thread Sergey Vasilenko
Keys should be immutable. If keys are not immutable -- it can lead to the situation, when network_metadata/nodes contains two records for same nodes (with same UID), but with different information. /sv __ OpenStack

Re: [openstack-dev] [Fuel] network_metadata hash keys on astute.yaml

2016-03-15 Thread Aleksey Kasatkin
Hi, I'm agree with Alex, keys should remain immutable. 'node-{uid}' is Okay, we have a method for this in Nailgun already. It should be a very simple fix in Nailgun. Thanks, Aleksey Kasatkin On Tue, Mar 15, 2016 at 3:19 PM, Kyrylo Galanov wrote: > Hi, > > I would

Re: [openstack-dev] [Fuel] network_metadata hash keys on astute.yaml

2016-03-15 Thread Kyrylo Galanov
Hi, I would like to remind that we are close to code freeze and bug is still there. Moreover, new bug reports continue to be submitted [3]. Please, do not ignore the discussion. [3] https://bugs.launchpad.net/fuel/+bug/1557417 On Tue, Mar 15, 2016 at 10:18 PM, Aleksandr Didenko

Re: [openstack-dev] [Fuel] network_metadata hash keys on astute.yaml

2016-03-15 Thread Aleksandr Didenko
Hi, some additional info on the problem: if I create some Hiera override for the nodes list and use node key which is hostname bond, then after node rename (rename during LCM or reset/rename/redeploy - doesn't matter) my override will create a "ghost" node in the list and will not change settings

[openstack-dev] [Fuel] network_metadata hash keys on astute.yaml

2016-03-15 Thread Kyrylo Galanov
Hi, Currently nailgun and puppet process network_metadata hash slightly different. Nailgun uses short hostname as a hash key for each node, while library code assumes that key is always 'node-{uid}'. Sometimes it can result in a deployment failure. During code review[0] it turned out that there