Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-07-07 Thread Radomir Dopieralski
On 08/07/14 08:29, Harshada Kakad wrote:> > HI All, > Could someone please, review the bug [...] Hello Harshada, please don't send such e-mails or ask in the IRC, submitting the patch is enough to get reviewers to read it, eventually. If we sent such an e-mail for every patch, this mailing list

[openstack-dev] [Horizon] request to review bug 1301359

2014-07-07 Thread Harshada Kakad
HI All, Could someone please, review the bug https://bugs.launchpad.net/horizon/+bug/1301359 Made Size parameter optional while creating DB Instance. While creating Database Instance size parameter depends on whether trove_volume_support is set. So size paramater is set to mandatory if trove_vol

Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Harshada Kakad
My patch actually does not relies on any not approved feature of a client. And I have not used any such features in my patch. Could you let me know which feature you are talking about which you think I have used, due to which patch would fail in integration testing? On Wed, Jun 4, 2014 at 6:14 PM

Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Matthias Runge
On Wed, Jun 04, 2014 at 04:13:33PM +0530, Harshada Kakad wrote: > HI Matthias Runge, > > Which feature in trove are you talking about? > And even which capabilities are missing which will make the patch fail? > I believe the patch has nothing to do with > https://review.openstack.org/#/c/83503/ I

Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Harshada Kakad
HI Matthias Runge, Which feature in trove are you talking about? And even which capabilities are missing which will make the patch fail? I believe the patch has nothing to do with https://review.openstack.org/#/c/83503/ On Wed, Jun 4, 2014 at 3:45 PM, Matthias Runge wrote: > On Wed, Jun 04, 2

Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Matthias Runge
On Wed, Jun 04, 2014 at 02:18:19PM +0530, Harshada Kakad wrote: > HI All, > Could someone please, review the bug > https://bugs.launchpad.net/horizon/+bug/1301359 > > > Made Size parameter optional while creating DB Instance. > > While creating Database Instance size parameter depends on > wheth

[openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Harshada Kakad
HI All, Could someone please, review the bug https://bugs.launchpad.net/horizon/+bug/1301359 Made Size parameter optional while creating DB Instance. While creating Database Instance size parameter depends on whether trove_volume_support is set. So size paramater is set to mandatory if trove_vol