On 21/08/14 18:05, Matthew Booth wrote:
[snip]
This seems to mean different things to different people. There's a list
here which contains some criteria for new commits:
[snip]
Any more of these?
There is also https://wiki.openstack.org/wiki/CodeReviewGuidelines
--
Radomir Dopieralski
On Thu, Aug 21, 2014 at 04:52:37PM -0500, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:53 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Thu, Aug 21, 2014 at 11:34:48AM -0500, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange
berra...@redhat.com
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project is better off without it.
I'm not quite sure how you make that translation, I would interpret -2 as
meaning the project would be better off without a change.
FWIW, I've
On Fri, Aug 22, 2014 at 10:49:51AM +0100, Steven Hardy wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I also think it's worth explicitly documenting a few things we
might/should mention in a review, but which aren't a reason that the
project would be better off
I would prefer that you didn't merge this.
i.e. The project is better off without it.
This seems to mean different things to different people. There's a list
here which contains some criteria for new commits:
https://wiki.openstack.org/wiki/ReviewChecklist.
There's also a treatise on git
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project is better off without it.
A bit off topic, but I've never liked this message that gets added
as it think it sounds overly negative. It would better written
as
This
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project is better off without it.
A bit off topic, but I've never liked this message that
On 08/21/2014 12:34 PM, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange
berra...@redhat.com mailto:berra...@redhat.com wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 21/08/14 18:34, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange
berra...@redhat.com mailto:berra...@redhat.com wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't
On Thu, Aug 21, 2014 at 11:34:48AM -0500, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project is better off
On Aug 21, 2014, at 9:42 AM, Adam Young ayo...@redhat.com wrote:
On 08/21/2014 12:34 PM, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't
On Thu, Aug 21, 2014 at 12:42:43PM -0400, Adam Young wrote:
On 08/21/2014 12:34 PM, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange berra...@redhat.com
mailto:berra...@redhat.com wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I
Comments inline below.
Best Regards,
Lance
On Thu, Aug 21, 2014 at 11:40 AM, Adam Young ayo...@redhat.com wrote:
On 08/21/2014 12:21 PM, Daniel P. Berrange wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project
On Thu, Aug 21, 2014 at 12:40:59PM -0400, Adam Young wrote:
On 08/21/2014 12:21 PM, Daniel P. Berrange wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project is better off without it.
A bit off topic, but I've never
On 21/08/14 12:21, Daniel P. Berrange wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project is better off without it.
A bit off topic, but I've never liked this message that gets added
as it think it sounds overly
On 08/21/2014 12:53 PM, Daniel P. Berrange wrote:
On Thu, Aug 21, 2014 at 11:34:48AM -0500, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge
On Thu, Aug 21, 2014 at 01:12:16PM -0400, Zane Bitter wrote:
On 21/08/14 12:21, Daniel P. Berrange wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project is better off without it.
A bit off topic, but I've never
On Thu, Aug 21, 2014 at 11:53 AM, Daniel P. Berrange berra...@redhat.com
wrote:
On Thu, Aug 21, 2014 at 11:34:48AM -0500, Dolph Mathews wrote:
On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange
berra...@redhat.com
wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
On 22/08/14 00:40, Adam Young wrote:
On 08/21/2014 12:21 PM, Daniel P. Berrange wrote:
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
I would prefer that you didn't merge this.
i.e. The project is better off without it.
A bit off topic, but I've never liked this message that
19 matches
Mail list logo
