Re: [openstack-dev] Openvswitch agent unit tests

Hello, Thx for Your tips. So I should focus more on write new functional tests for ovs agent if there are missing some rather then doing unit tests for it? -- Best regards / Pozdrawiam Sławek Kapłoński sla...@kaplonski.pl On Mon, 28 Sep 2015, Assaf Muller wrote: > Generally speaking, testing

Re: [openstack-dev] Openvswitch agent unit tests

On Tue, Sep 29, 2015 at 5:00 PM, Sławek Kapłoński wrote: > Hello, > > Thx for Your tips. So I should focus more on write new functional tests > for ovs agent if there are missing some rather then doing unit tests for > it? > If a method is conceivably testable with unit

[openstack-dev] Openvswitch agent unit tests

Hello, I'm new developer who want to start contributing to neutron. I have some small experience with neutron already but I didn't do anything which I could push to upstream for now. So I searched for some bug on launchpad and I found such bug which I took:

Re: [openstack-dev] Openvswitch agent unit tests

Generally speaking, testing agent methods that interact with the system heavily with unit tests provide very little, and arguably negative value to the project. Mocking internal methods and asserting that they were called is a clear anti-pattern to my mind. In Neutron-land we prefer to test agent