I got a -1 on a review for a standards violation that isn't caught by the
automated checks, so I was wondering why the automated check doesn't catch it.
The violation was:
from X import Y, Z
According to the coding standards page on the openstack wiki, the coding
standards are PEP8 (they
On 01/07/2014 09:26 AM, Greg Hill wrote:
I got a -1 on a review for a standards violation that isn't caught by
the automated checks, so I was wondering why the automated check doesn't
catch it. The violation was:
from X import Y, Z
According to the coding standards page on the openstack wiki,
Thanks Sean. I'll work on adding this one to the hacking repo. That brings up
another question, though, what are the implications of suddenly enforcing a
rule that wasn't previously enforced? I know there are at least 30 other
violations of this rule just within trove, and I imagine larger
Yes, you turn it off. Once the change to enforce this rule is merged
into hacking, other projects can start refresh their hacking
dependency (e.g. upgrading to latest version). The patch to update
the dependency has to turn the newly added check off and then
consecutive patches can fix all
On 01/07/2014 10:19 AM, Greg Hill wrote:
Thanks Sean. I'll work on adding this one to the hacking repo. That brings
up another question, though, what are the implications of suddenly enforcing
a rule that wasn't previously enforced? I know there are at least 30 other
violations of this
So it turns out that trove just has this rule disabled. At least I now know
more about how this stuff works, I guess. Sorry for the confusion.
Greg
On Jan 7, 2014, at 9:54 AM, Sean Dague s...@dague.net wrote:
On 01/07/2014 10:19 AM, Greg Hill wrote:
Thanks Sean. I'll work on adding this
